Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add check if the covenant is the covenant committee #91

Merged
merged 14 commits into from
Jan 13, 2025
Merged

feat: add check if the covenant is the covenant committee #91

merged 14 commits into from
Jan 13, 2025

Conversation

RafilxTenfen
Copy link
Contributor

@RafilxTenfen RafilxTenfen commented Jan 10, 2025 •
edited
Loading

Add verification if the parameter of the versioned BTC delegation was included contains the covenant committee public key in his list

@RafilxTenfen RafilxTenfen self-assigned this Jan 10, 2025
@RafilxTenfen RafilxTenfen changed the title fix: add check if the covenant is the covenant committee of that btc … fix: add check if the covenant is the covenant committee Jan 10, 2025
@RafilxTenfen RafilxTenfen changed the title fix: add check if the covenant is the covenant committee feat: add check if the covenant is the covenant committee Jan 10, 2025
@RafilxTenfen RafilxTenfen marked this pull request as ready for review January 10, 2025 23:45
@RafilxTenfen RafilxTenfen linked an issue Jan 10, 2025 that may be closed by this pull request
Covenant emulator does not check whether it is part of the committe #89
Closed
@RafilxTenfen
Copy link
Contributor Author

RafilxTenfen commented Jan 10, 2025 •
edited
Loading

My first thought here was to reconstruct the unbonding path to verify based on the staking Tx, but that was a waste of time as we can get it all parsed from the versioned parameter

KonradStaniec
KonradStaniec reviewed Jan 12, 2025
View reviewed changes
covenant/cache_params.go Outdated Show resolved Hide resolved
covenant/cache_params.go Show resolved Hide resolved
covenant/covenant.go Outdated Show resolved Hide resolved
KonradStaniec
KonradStaniec reviewed Jan 13, 2025
View reviewed changes
covenant/covenant.go Outdated Show resolved Hide resolved
KonradStaniec
KonradStaniec reviewed Jan 13, 2025
View reviewed changes
covenant/covenant.go Outdated Show resolved Hide resolved
covenant/covenant.go Outdated Show resolved Hide resolved
KonradStaniec
KonradStaniec approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few final comments and lgtm 👍

covenant/covenant.go Outdated Show resolved Hide resolved
covenant/covenant.go Show resolved Hide resolved
@RafilxTenfen RafilxTenfen merged commit 37d715e into main Jan 13, 2025
23 checks passed
RafilxTenfen added a commit that referenced this pull request Jan 13, 2025
@RafilxTenfen
feat: add check if the covenant is the covenant committee (#91)
322d692 
* fix: add check if the covenant is the covenant committee of that btc delegation based on the params version

* chore: refactory sanitize delegations

* chore: add #91 to changelog

* chore: add godoc to funcs

* chore: add client controller and logger directly to param cache

* chore: refactory to remove delegations in a single loop over dels

* chore: add check for del copy

* chore: removed delCopy

* fix: test check endheight modified

* chore: add test that verifies if all the delegations pointers wasn't pointing to the last one

* chore: return error in func IsKeyInCommittee and log if there is a error

* chore: stop the loop if there is an error in sanitize delegations

* chore: address pr comments, transform err from %s to %w and add check if sanitized dels returns some delegation
RafilxTenfen added a commit that referenced this pull request Jan 13, 2025
@RafilxTenfen
chore: changelog release v0.11.3 with #91 PR
e4e9498
RafilxTenfen added a commit that referenced this pull request Jan 13, 2025
@RafilxTenfen
feat: add check if the covenant is the covenant committee (#91)
e7be168 
* fix: add check if the covenant is the covenant committee of that btc delegation based on the params version

* chore: refactory sanitize delegations

* chore: add #91 to changelog

* chore: add godoc to funcs

* chore: add client controller and logger directly to param cache

* chore: refactory to remove delegations in a single loop over dels

* chore: add check for del copy

* chore: removed delCopy

* fix: test check endheight modified

* chore: add test that verifies if all the delegations pointers wasn't pointing to the last one

* chore: return error in func IsKeyInCommittee and log if there is a error

* chore: stop the loop if there is an error in sanitize delegations

* chore: address pr comments, transform err from %s to %w and add check if sanitized dels returns some delegation
RafilxTenfen added a commit that referenced this pull request Jan 13, 2025
@RafilxTenfen
chore: release v0.11.3 with backport of #91 (#93)
5d5ad1f 
* feat: add check if the covenant is the covenant committee (#91)

* fix: add check if the covenant is the covenant committee of that btc delegation based on the params version

* chore: refactory sanitize delegations

* chore: add #91 to changelog

* chore: add godoc to funcs

* chore: add client controller and logger directly to param cache

* chore: refactory to remove delegations in a single loop over dels

* chore: add check for del copy

* chore: removed delCopy

* fix: test check endheight modified

* chore: add test that verifies if all the delegations pointers wasn't pointing to the last one

* chore: return error in func IsKeyInCommittee and log if there is a error

* chore: stop the loop if there is an error in sanitize delegations

* chore: address pr comments, transform err from %s to %w and add check if sanitized dels returns some delegation

* chore: changelog release v0.11.3 with #91 PR
RafilxTenfen added a commit that referenced this pull request Jan 28, 2025
@RafilxTenfen
feat: add check if the covenant is the covenant committee (#91)
9fc9137 
* fix: add check if the covenant is the covenant committee of that btc delegation based on the params version

* chore: refactory sanitize delegations

* chore: add #91 to changelog

* chore: add godoc to funcs

* chore: add client controller and logger directly to param cache

* chore: refactory to remove delegations in a single loop over dels

* chore: add check for del copy

* chore: removed delCopy

* fix: test check endheight modified

* chore: add test that verifies if all the delegations pointers wasn't pointing to the last one

* chore: return error in func IsKeyInCommittee and log if there is a error

* chore: stop the loop if there is an error in sanitize delegations

* chore: address pr comments, transform err from %s to %w and add check if sanitized dels returns some delegation
RafilxTenfen added a commit that referenced this pull request Jan 28, 2025
@RafilxTenfen
feat: add check if the covenant is the covenant committee (#91)
85db51c 
* fix: add check if the covenant is the covenant committee of that btc delegation based on the params version

* chore: refactory sanitize delegations

* chore: add #91 to changelog

* chore: add godoc to funcs

* chore: add client controller and logger directly to param cache

* chore: refactory to remove delegations in a single loop over dels

* chore: add check for del copy

* chore: removed delCopy

* fix: test check endheight modified

* chore: add test that verifies if all the delegations pointers wasn't pointing to the last one

* chore: return error in func IsKeyInCommittee and log if there is a error

* chore: stop the loop if there is an error in sanitize delegations

* chore: address pr comments, transform err from %s to %w and add check if sanitized dels returns some delegation
@RafilxTenfen RafilxTenfen deleted the rafilx/check-part-committe branch January 28, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonradStaniec KonradStaniec KonradStaniec approved these changes

@gitferry gitferry Awaiting requested review from gitferry

Assignees

@RafilxTenfen RafilxTenfen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Covenant emulator does not check whether it is part of the committe
2 participants
@RafilxTenfen @KonradStaniec