Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove opt to remote signer, should always use remote signer #95

Merged
merged 11 commits into from
Jan 15, 2025

Conversation

RafilxTenfen
Copy link
Contributor

Closes: #90

@RafilxTenfen RafilxTenfen self-assigned this Jan 14, 2025
@RafilxTenfen RafilxTenfen marked this pull request as ready for review January 14, 2025 22:38
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm except e2e test failure. Some minors on the doc

docs/covenant-emulator-setup.md Outdated Show resolved Hide resolved
docs/covenant-emulator-setup.md Outdated Show resolved Hide resolved
docs/covenant-emulator-setup.md Outdated Show resolved Hide resolved
docs/covenant-emulator-setup.md Outdated Show resolved Hide resolved
@RafilxTenfen
Copy link
Contributor Author

@KonradStaniec I will wait for your review again to merge

Copy link
Member

@Lazar955 Lazar955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@RafilxTenfen RafilxTenfen merged commit 0a7fd83 into main Jan 15, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove option to run covenant-emulator without remote signer
4 participants