Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pagination to queryDelegationsWithStatus #96

Merged
merged 8 commits into from
Jan 20, 2025

Conversation

RafilxTenfen
Copy link
Contributor

@RafilxTenfen RafilxTenfen commented Jan 15, 2025

The query should loop by the max limit set in the config delegationlimit, since the BTC delegations already signed and the ones in which the covenant pub key was not constructed with are being removed by sanitizeDelegations

Closes: #92

@RafilxTenfen RafilxTenfen marked this pull request as ready for review January 16, 2025 15:50
@RafilxTenfen RafilxTenfen requested a review from Lazar955 January 16, 2025 18:33
Copy link
Member

@Lazar955 Lazar955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Minor comments

clientcontroller/babylon.go Show resolved Hide resolved
covenant/covenant_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

covenant/covenant_test.go Outdated Show resolved Hide resolved
@RafilxTenfen RafilxTenfen merged commit 58904be into main Jan 20, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix query loop in covenant evmulator
3 participants