Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delegation iter #171

Merged
merged 7 commits into from
Jan 14, 2025
Merged

fix: delegation iter #171

merged 7 commits into from
Jan 14, 2025

Conversation

Lazar955
Copy link
Member

Debug logs for testnet

@Lazar955 Lazar955 changed the title chore: adds more logs to staking event watcher fix: delegation iter Jan 14, 2025
KonradStaniec
KonradStaniec approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write in a bit more detail what was happning and how the changes fixes the problem (also it would be nice to have some test showing what happened can be done in separate pr)

@Lazar955 Lazar955 mentioned this pull request Jan 14, 2025
Open
@Lazar955
Copy link
Member Author

Lazar955 commented Jan 14, 2025 •
edited
Loading

Could you write in a bit more detail what was happning and how the changes fixes the problem (also it would be nice to have some test showing what happened can be done in separate pr)

Yes, created an issue for the testcase for this.

The issue was a combination of high contention as there are write to the pending tracker and reads from it and the fact that we could be yielding the same item (due the fact that we are writing to a map), fixed by the processed map. We were never stoppin processing items in the previous code, but processing them really really slow after first iteration

@Lazar955 Lazar955 merged commit 31468cb into main Jan 14, 2025
13 checks passed
@Lazar955 Lazar955 deleted the lazar/debug-sew branch January 14, 2025 15:11
Lazar955 added a commit that referenced this pull request Jan 14, 2025
@Lazar955
fix: delegation iter (#171)
0d0269d 
Debug logs for testnet
Lazar955 added a commit that referenced this pull request Jan 14, 2025
@Lazar955
fix: delegation iter (#171) [backport] (#174)
8e5783e 
Debug logs for testnet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonradStaniec KonradStaniec KonradStaniec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lazar955 @KonradStaniec