Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment: V3 Vault #124

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Deployment: V3 Vault #124

merged 3 commits into from
Dec 5, 2024

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Dec 4, 2024

Deployment: V3 Vault

Deployment tasks checklist:

  • Contract(s) deployed to all target networks / testnets
  • TX IDs are properly generated
  • Action IDs are generated after deployment (if applicable)
  • Outputs for all target networks are generated, and linked in the task readme
  • Addresses files are up to date with the new deployment
  • Contracts are verified in every network
  • Deployments CHANGELOG is updated
  • There are no code changes of any kind
    • Gas limit changed to please Gnosis. All good.

Issue Resolution

N/A

EndymionJkb
EndymionJkb approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MattPereira MattPereira mentioned this pull request Dec 5, 2024
Merged
@jubeira jubeira merged commit 116f46b into master Dec 5, 2024
30 checks passed
@jubeira jubeira deleted the deployment/v3-vault branch December 5, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndymionJkb EndymionJkb EndymionJkb approved these changes

@joaobrunoah joaobrunoah Awaiting requested review from joaobrunoah

@elshan-eth elshan-eth Awaiting requested review from elshan-eth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jubeira @EndymionJkb