Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add factory name to action IDs generator / checks #153

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Jan 23, 2025

Description

CI fails in #152 because the pools are called StablePool, but the factory is StableSurgePoolFactory instead of <contract>Factory.

This is an edge case but might happen again in the future, and in any case we need CI to pass with the current deployment. This change adds one more optional parameter that allows indicating what the factory name is.

It's backwards compatible; if the usual format is respected there's no need to use the new argument. But in this case, the command looks like this:

hh save-action-ids --id 20250121-v3-stable-surge --network sepolia --name StablePool --address 0x132F4bAa39330d9062fC52d81dF72F601DF8C01f --factory StableSurgePoolFactory

Merge this one on top of #152 first, then merge #152 so that CI passes.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • N/A Complex code has been commented, including external interfaces
  • N/A Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

@jubeira jubeira requested a review from EndymionJkb January 23, 2025 02:09
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jubeira jubeira merged commit ff003f9 into deployment/stable-surge-hook Jan 23, 2025
30 checks passed
@jubeira jubeira deleted the action-ids-factory-name branch January 23, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants