Add factory name to action IDs generator / checks #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI fails in #152 because the pools are called
StablePool
, but the factory isStableSurgePoolFactory
instead of<contract>Factory
.This is an edge case but might happen again in the future, and in any case we need CI to pass with the current deployment. This change adds one more optional parameter that allows indicating what the factory name is.
It's backwards compatible; if the usual format is respected there's no need to use the new argument. But in this case, the command looks like this:
Merge this one on top of #152 first, then merge #152 so that CI passes.
Type of change
Checklist:
master
, or there's a description of how to mergeIssue Resolution
N/A