Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment preparation: MevTaxHook #159

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Jan 27, 2025

Deployment preparation: MevTaxHook

build-info: balancer/balancer-v3-monorepo@11ac09b

Deployment preparation tasks checklist:

  • Deployments README is updated with the new task name and link
  • Task README has a description and links to the artifacts
  • build-info is updated with artifacts compiled at the specified commit
  • Artifacts are generated from build-info
  • New task has a working fork test (In Sepolia, given that we need the registry)

Deprecating old tasks checklist: N/A

Code checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented in tests and scripts
  • Fork test block number and test cases are appropriate for this deployment
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

@jubeira jubeira requested a review from EndymionJkb January 27, 2025 15:59
EndymionJkb
EndymionJkb previously approved these changes Jan 27, 2025
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just a couple comment suggestions. I confirm the build info matches.

v3/tasks/20250125-v3-mev-tax-hook/readme.md Outdated Show resolved Hide resolved
v3/tasks/20250125-v3-mev-tax-hook/readme.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LEBTM!

@jubeira jubeira merged commit 6dd5662 into master Jan 27, 2025
30 checks passed
@jubeira jubeira deleted the deployment-preparation/mev-tax-hook branch January 27, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants