Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: os: expand iptables rules tests to include ip6tables rules #3493

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests: os: expand iptables rules tests to include ip6tables rules #3493

wants to merge 1 commit into from

Conversation

rcooke-warwick
Copy link
Contributor

The supervisor uses different iptables binaries for ipv4 and ipv6 rules, so we should check it adds rules for both, inc ase there is a problem with ip6tables

Change-type: patch

Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

Website deployed to CF Pages, 👀 preview link https://f561e2ca.balena-os.pages.dev

@flowzone-app flowzone-app bot enabled auto-merge August 16, 2024 15:42
@kb2ma
Copy link
Contributor

kb2ma commented Aug 16, 2024

Looks good to me, @rcooke-warwick. I verified that the BALENA-FIREWALL chain has at least 10 entries on a recent device. Is it feasible to run at least this one test locally to confirm?

@pipex
Copy link
Contributor

pipex commented Aug 16, 2024

Looks good to me too @rcooke-warwick

@rcooke-warwick
Copy link
Contributor Author

depends on #3484 to be able to pass - at the moment it correctly fails

@rcooke-warwick
tests: os: expand iptables rules tests to include ip6tables rules
3010b96 
The supervisor uses different iptables binaries for ipv4 and ipv6 rules, so we should check it adds rules for both, inc ase there is a problem with ip6tables

Change-type: patch
Signed-off-by: Ryan Cooke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgg alexgg Awaiting requested review from alexgg

@pipex pipex Awaiting requested review from pipex

@kb2ma kb2ma Awaiting requested review from kb2ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcooke-warwick @kb2ma @pipex