Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Avatar component and fix mapping key issue in AnimatePresence component #137

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

ballyalley-o
Copy link
Owner

in-a-iii and others added 2 commits April 15, 2024 02:24
* moved avatar interface to global

* removed unused import

* moved IDefaultAvatar to global, and renamed from DefaultAvatarProps

* Typoghraphy constants: Update avatar component typography constants

* Add typography constants

* Add typography constants

---------

Co-authored-by: bally <[email protected]>
* Refactor AccountPopover component to use index as key in MenuItem

* 🐞 fix([BUG] Mapping key has multiple children #128: Solution: Refactor use-snack.tsx to import React and update AnimatePresence usage):

* destructure Children from react instead #136: Update import statement in use-snack.tsx
@ballyalley-o ballyalley-o requested a review from in-a-iii April 15, 2024 10:25
@ballyalley-o ballyalley-o self-assigned this Apr 15, 2024
Copy link
Collaborator

@in-a-iii in-a-iii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@in-a-iii in-a-iii merged commit 8055507 into main Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants