Feedback Slice, Feedback Quote bubble component, and Perf related #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andle invalid credentials error in LogIn component
… Update navbar styling and remove unused code
Add NO_FEEDBACK placeholder to constant/placeholder.ts
…t for displaying feedback quotes
…t for displaying feedback quotes
…r and persist configuration):
…und color for SCard
…-slice Refactor Navbar Drawer
in-a-iii
approved these changes
May 11, 2024
This was
linked to
issues
May 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request fixes the issue of a failed authentication in the login page throwing an exception. It also includes some refactoring and feature additions.
Commits:
feat: add APPLY_FOR_COURSE label to constant/label.ts
refactor: Add collapse table component to CourseRow for better code organization
refactor: Add CollapseGrid component to Bootcamp section for better code organization
🐞 fix(refactor: Adjust position of GSBadgeImg in main.ts):
refactor: Update background styling in AppForm component
refactor: Remove commented out code in main.tsx
[BUG] Failed Auth in Login page throws an exemption [BUG] Failed Auth in Login page throws an exemption #167
[BUG] Failed Auth in Login page throws an exemption [BUG] Failed Auth in Login page throws an exemption #167: refactor: Handle invalid credentials error in LogIn component
[Client] TCCPISSUE: Refactor Navbar Drawer [Client] TCCPISSUE: Refactor Navbar Drawer #141: [Clean-up] refactor: Update navbar styling and remove unused code
Redux | Feedback Slice Redux | Feedback Slice #17: Add FEEDBACK route to routing constants
Add FEEDBACKS and TAGS labels to constant/label.ts
update placeholder.ts
refactor: Adjust padding in main.tsx
Optimized Bootcamp page with lazy loading for images
feat: Add BOOTCAMP_FEEDBACK route to ServerPath class
[Client] Feat: Feedback Quote buble [Client] Feat: Feedback Quote buble #171: Add FeedbackBubble component for displaying feedback quotes
[Client] Feat: Feedback Quote buble [Client] Feat: Feedback Quote buble #171: Add FeedbackBubble component for displaying feedback quotes
chore: Remove unused Bootcamp component and export statement
feat: Add QuoteBubble component for displaying feedback quotes
Slices-reducer: Bootcamp - Feedback
Redux | Feedback Slice Redux | Feedback Slice #17: Add feedback endpoint and slice for API integration
🎈 perf(Redux | Feedback Slice Redux | Feedback Slice #17: Add feedbackReducer to root-reducer and persist configuration):
chore: Update main.ts to include flex display and transparent background color for SCard
refactor: Update palette.ts to fix primary and background colors
🐳 chore(chore: Update npm dependencies):
Merge pull request Feedback Slice, QuoteBubble and some Redux stuff #178 from ballyalley-o/feat/TCCP17-redux--feedback-slice
Refactor Navbar Drawer
Please let me know if you need any further assistance.