Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate scaled factors for pixel with react-native-pixel-perfect #126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

giolaq
Copy link
Contributor

@giolaq giolaq commented May 21, 2024

I've found the using react-native-pixel-perfect makes it easier to adapt the scaling factor across different screens.

The library is considering width and height that can be defined by the developers or runtime.

Tested on Android TV, Fire TV, tvOS and web.

Check if it makes sense! Thank you!

@pierpo
Copy link
Member

pierpo commented May 27, 2024

It makes sense but I'm not sure there is that much added value: the calculation is very simple and is present only once in the codebase, in a separate place 😁
I'm not sure we need to add a dependency for that!

Maybe there are additional features that I missed?
Would be nice to define it at runtime but I'm not sure components would re-render, since this is computed at root level.

@giolaq
Copy link
Contributor Author

giolaq commented May 28, 2024

Agree that adding a dependency for this is an overkill. I found that testing on Fire TV/Android TV emulator/Web was giving me some issue with the UI not following the same proportions. I have tested with the react-native-pixel-perfect and all was fixed. I think their formula maybe is more completed as taking as variable also the height.
Let me get back with more testing and some screenshots 🙏 probably we can just modify the calculation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants