Merge pull request #582 from sanieni6/bug/throwDepthError

refactor(groupsValidation): throw BadRequestException on invalid treeDepth input
bandada-infra · Oct 23, 2024 · a9e6146 · a9e6146
2 parents 5b19cf7 + 47aaaec
commit a9e6146
Show file tree

Hide file tree

Showing 5 changed files with 55 additions and 2 deletions.
diff --git a/apps/api/src/app/groups/dto/create-group.dto.ts b/apps/api/src/app/groups/dto/create-group.dto.ts
@@ -31,8 +31,8 @@ export class CreateGroupDto {
     readonly description: string
 
     @IsNumber()
-    @Min(16)
-    @Max(32)
+    @Min(16, { message: "The tree depth must be between 16 and 32." })
+    @Max(32, { message: "The tree depth must be between 16 and 32." })
     @ApiProperty()
     readonly treeDepth: number
 

diff --git a/apps/api/src/app/groups/groups.service.test.ts b/apps/api/src/app/groups/groups.service.test.ts
@@ -90,6 +90,22 @@ describe("GroupsService", () => {
             expect(treeDepth).toBe(16)
             expect(members).toHaveLength(0)
         })
+
+        it("Should not create a group if the treeDepth is not between 16 and 32", async () => {
+            const fun = groupsService.createGroup(
+                {
+                    name: "Group3",
+                    description: "This is a description",
+                    treeDepth: 15,
+                    fingerprintDuration: 3600
+                },
+                "admin"
+            )
+
+            await expect(fun).rejects.toThrow(
+                "The tree depth must be between 16 and 32."
+            )
+        })
     })
 
     describe("# removeGroup", () => {

diff --git a/apps/api/src/app/groups/groups.service.ts b/apps/api/src/app/groups/groups.service.ts
@@ -163,6 +163,12 @@ export class GroupsService {
 
         if (credentials === undefined) credentials = null
 
+        if (treeDepth < 16 || treeDepth > 32) {
+            throw new BadRequestException(
+                "The tree depth must be between 16 and 32."
+            )
+        }
+
         const group = this.groupRepository.create({
             id: _groupId,
             name,

diff --git a/libs/api-sdk/src/apiSdk.ts b/libs/api-sdk/src/apiSdk.ts
@@ -121,6 +121,13 @@ export default class ApiSdk {
         groupCreationDetails: GroupCreationDetails,
         apiKey: string
     ): Promise<Group> {
+        if (
+            groupCreationDetails.treeDepth < 16 ||
+            groupCreationDetails.treeDepth > 32
+        ) {
+            throw new Error("The tree depth must be between 16 and 32")
+        }
+
         const groups = await createGroups(
             this._config,
             [groupCreationDetails],
@@ -140,6 +147,12 @@ export default class ApiSdk {
         groupsCreationDetails: Array<GroupCreationDetails>,
         apiKey: string
     ): Promise<Array<Group>> {
+        for (const group of groupsCreationDetails) {
+            if (group.treeDepth < 16 || group.treeDepth > 32) {
+                throw new Error("The tree depth must be between 16 and 32")
+            }
+        }
+
         const groups = await createGroups(
             this._config,
             groupsCreationDetails,

diff --git a/libs/api-sdk/src/index.test.ts b/libs/api-sdk/src/index.test.ts
@@ -309,6 +309,24 @@ describe("Bandada API SDK", () => {
                     expect(group.credentials).toBeNull()
                 })
             })
+
+            it("Should not create a group if the treeDepth is not between 16 and 32", async () => {
+                const expectedGroups: Array<GroupCreationDetails> = [
+                    {
+                        name: "Group3",
+                        description: "This is a new group",
+                        treeDepth: 15,
+                        fingerprintDuration: 3600
+                    }
+                ]
+                const apiKey = "70f07d0d-6aa2-4fe1-b4b9-06c271a641dc"
+                apiSdk = new ApiSdk(SupportedUrl.DEV)
+                const fun = apiSdk.createGroups([expectedGroups[0]], apiKey)
+
+                await expect(fun).rejects.toThrow(
+                    "The tree depth must be between 16 and 32"
+                )
+            })
         })
         describe("#removeGroup", () => {
             it("Should create a group", async () => {