Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing test case to check if the same credential with different identities can join different groups #329

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

0xjei
Copy link
Contributor

@0xjei 0xjei commented Nov 9, 2023

Description

This PR adds a test case to the credential service to verify that the same credential (same OAuth account) can be associated with different identities at the same time, and that each of them can join a different group.

  • Added missing test case
  • Changed the provider from twitter to github as we are GITHUB_FOLLOWERS as credentials.

Related Issue

Closes #305

Does this introduce a breaking change?

  • Yes
  • No

Other information

Depends on #325

@0xjei 0xjei added the tests 🧪 Adding missing or correcting existing tests label Nov 9, 2023
@0xjei 0xjei self-assigned this Nov 9, 2023
@vplasencia vplasencia changed the base branch from dev to feat/many-to-many-group-member November 9, 2023 11:00
@vplasencia vplasencia merged commit befa1cc into feat/many-to-many-group-member Nov 9, 2023
@vplasencia vplasencia deleted the test/same-credentials branch November 10, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests 🧪 Adding missing or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can´t reuse the same credential with different identities in different groups
2 participants