-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bandada docs inside apps
folder
#427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I noticed that running yarn start
results in an error for the Nest
application due to the 3000
port being already occupied by docusaurus
. Thank you for your work!
[Nest] 254486 - 03/07/2024, 11:04:28 PM LOG [NestApplication] Nest application successfully started +3ms
[Nest] 254486 - 03/07/2024, 11:04:28 PM ERROR [NestApplication] Error: listen EADDRINUSE: address already in use :::3000 +1ms
node:internal/errors:563
ErrorCaptureStackTrace(err);
^
Error: listen EADDRINUSE: address already in use :::3000
at Server.setupListenHandle [as _listen2] (node:net:1872:16)
at listenInCluster (node:net:1920:12)
at Server.listen (node:net:2008:7)
at ExpressAdapter.listen (/home/giacomo/Documents/EF/Code/bandada/node_modules/@nestjs/platform-express/adapters/express-adapter.js:88:32)
at /home/giacomo/Documents/EF/Code/bandada/node_modules/@nestjs/core/nest-application.js:180:30
at new Promise (<anonymous>)
at NestApplication.listen (/home/giacomo/Documents/EF/Code/bandada/node_modules/@nestjs/core/nest-application.js:169:16)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async bootstrap (/home/giacomo/Documents/EF/Code/bandada/apps/api/dist/main.js:109:5) {
code: 'EADDRINUSE',
errno: -98,
syscall: 'listen',
address: '::',
port: 3000
}
Node.js v20.11.0
✔ Client: Compiled successfully in 4.21s
client (webpack 5.90.3) compiled successfully
apps/docs/docusaurus.config.ts
Outdated
favicon: "img/favicon.ico", | ||
|
||
// Set the production url of your site here | ||
url: "https://your-docusaurus-site.example.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change also these default values url
, organizationName
, projectName
and editUrl
. Otherwise, if aren't needed, we can get rid of them for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update these values, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated everything with the new Bandada org because we will move the repo this week.
apps/docs/package.json
Outdated
@@ -0,0 +1,47 @@ | |||
{ | |||
"name": "bandada-docs", | |||
"version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least 0.0.1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I will remove that version
property because it's not necessary.
Hey @0xjei, thanks for pointing it out. I will add |
Sweet, thank you @vplasencia :) |
Description
This PR adds the Bandada documentation inside the
apps
folder.Related Issue
#426
Does this introduce a breaking change?