Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues #636 #654

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Fix issues #636 #654

merged 2 commits into from
Jan 21, 2025

Conversation

pheobeayo
Copy link
Contributor

added the numbers of groups for my groups and all credential groups on the group page

Description

added the numbers of groups for my groups and all credential groups on the group page

Added the numbers of groups for my groups and all credential groups on the group page

Related Issue

#636

#636

Does this introduce a breaking change?

  • Yes
  • [ -] No

Other information

Checklist

  • [ -] I have performed a self-review of my code
  • [- ] I have commented my code, particularly in hard-to-understand areas
  • [- ] My changes generate no new warnings
  • [- ] I have run yarn prettier and yarn lint without getting any errors
  • [ -] I have added tests that prove my fix is effective or that my feature works
  • [- ] New and existing unit tests pass locally with my changes

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

…oup and all credentials groups

added number of groups next to my groups and all credential groups
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 0:09am
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 0:09am

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update this branch with the main branch?

@pheobeayo
Copy link
Contributor Author

Could you please update this branch with the main branch?

done @vplasencia

@pheobeayo pheobeayo requested a review from vplasencia January 21, 2025 09:59
@vplasencia
Copy link
Member

Hey @pheobeayo can you try again? because just one file should change here: https://github.com/bandada-infra/bandada/pull/654/files

@pheobeayo
Copy link
Contributor Author

Hey @pheobeayo can you try again? because just one file should change here: https://github.com/bandada-infra/bandada/pull/654/files

I have updated it now @vplasencia

@vplasencia vplasencia changed the base branch from main to dev January 21, 2025 12:29
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you very much @pheobeayo! 🚀

@vplasencia vplasencia merged commit e5037a4 into bandada-infra:dev Jan 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants