Setup generic functionality #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bence Csati <[email protected]>
Closed
1 task
ramizpolic
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
LGTM, the PR looks clean 🌟 , well done @csatib02! I have left a couple of notes to consider, but nothing major. I think a bit more documentation about the configuration and usage would be quite useful, but this can be addressed in the upcoming PRs.
sagikazarmark
requested changes
Oct 25, 2023
Signed-off-by: Bence Csati <[email protected]>
Signed-off-by: Bence Csati <[email protected]>
Signed-off-by: Bence Csati <[email protected]>
Signed-off-by: Bence Csati <[email protected]>
sagikazarmark
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is mostly a refactor of the original vault-env without the vault provider implementation. It has a generic main functionality, which works by adding "-p {name of the desired provider}" to the beginning of the command line arguments, then it gets removed from the args, so the rest of the code mostly can remain the same as it was in vault-env.
I used a map to determine which provider is being used, so it is easy to extended.
Also I moved the logger part of the code from main, to a separate folder, so it can be reused by the providers.
Start of issue: #1