Fix comments and some renaming for JOSE submission #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added in the typo fix for |
petebachant
reviewed
Jul 10, 2018
lessons/02_Step_2.ipynb
Outdated
| @@ -27,7 +27,7 @@ | |||
| "cell_type": "markdown", | |||
| "metadata": {}, | |||
| "source": [ | |||
| "This IPython notebook continues the presentation of the **12 steps to Navier-Stokes**, the practical module taught in the interactive CFD class of [Prof. Lorena Barba](http://lorenabarba.com). You should have completed [Step 1](./01_Step_1.ipynb) before continuing, having written your own Python script or notebook and having experimented with varying the parameters of the discretization and observing what happens.\n" | |||
| "This IPython notebook continues the presentation of the **12 steps to Navier–Stokes**, the practical module taught in the interactive CFD class of [Prof. Lorena Barba](http://lorenabarba.com). You should have completed [Step 1](./01_Step_1.ipynb) before continuing, having written your own Python script or notebook and having experimented with varying the parameters of the discretization and observing what happens.\n" | |||
There was a problem hiding this comment.
"IPython" can be changed to "Jupyter" here.
Resolves #44 For openjournals/jose-reviews#21
The two Numba notebooks are not at all up-to-date and also don't contain any content that is required to complete the course. The Burgers notebook was never finished but can be picked up for a separate lesson/course later (it still exists in the history of this repo). The odd even decoupling notebook was started as an extra resource to explain some behavior in the solution of the cavity flow problem. Might stick it somewhere else later. Since we had the Numba notebook as the 14th out of 16 total notebooks, I've shifted the leading numbers of Steps 11 and 12 down by one.
This is in addition to the `quiver` plot that was already there.
|
Spoke in person with @labarba and will merge this in now. Still a few things to address but these can all be edited/adjusted individually as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For openjournals/jose-reviews#21
Should resolve #45