Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use php-debugbar dark theme, move to variables #1717

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

barryvdh
Copy link
Owner

@barryvdh barryvdh commented Jan 12, 2025

This is pending on php-debugbar/php-debugbar#703

  • Move hardcoded colors to CSS variables
  • Add a dark theme for php-debugbar, based on CSS variables
  • Move hardcoded colors for laravel-debugbar to CSS variable overrides
  • Tweak Laravel-debugbar darkmode to only use CSS variables.

This should make it easier to maintain both themes, if the existing variables are used. And a lot less CSS duplication.

Some color overrides should probably still be done in php-debugbar instead of here.

Note: This requires the feat-darktheme branch for debugbar to work.

@barryvdh barryvdh marked this pull request as draft January 12, 2025 14:38
@barryvdh
Copy link
Owner Author

I think this is done, but requires the latest php-debugbar beta.

@barryvdh barryvdh marked this pull request as ready for review January 26, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant