Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use php-debugbar dark theme, move to variables #1717

Merged
merged 17 commits into from
Jan 30, 2025

Conversation

barryvdh
Copy link
Owner

@barryvdh barryvdh commented Jan 12, 2025

This is pending on php-debugbar/php-debugbar#703

  • Move hardcoded colors to CSS variables
  • Add a dark theme for php-debugbar, based on CSS variables
  • Move hardcoded colors for laravel-debugbar to CSS variable overrides
  • Tweak Laravel-debugbar darkmode to only use CSS variables.

This should make it easier to maintain both themes, if the existing variables are used. And a lot less CSS duplication.

Some color overrides should probably still be done in php-debugbar instead of here.

Note: This requires the feat-darktheme branch for debugbar to work.

@barryvdh barryvdh marked this pull request as draft January 12, 2025 14:38
@barryvdh
Copy link
Owner Author

I think this is done, but requires the latest php-debugbar beta.

@barryvdh barryvdh marked this pull request as ready for review January 26, 2025 17:55
@barryvdh barryvdh merged commit 11eebec into master Jan 30, 2025
33 checks passed
@barryvdh barryvdh deleted the feat-debugbar-themes branch January 30, 2025 19:06
@erikn69
Copy link
Contributor

erikn69 commented Jan 30, 2025

Hello, the opener modal has no theme colors, is this intentional?
image

@barryvdh
Copy link
Owner Author

Hmm no, it should have. Did you do a hard refresh?

@erikn69
Copy link
Contributor

erikn69 commented Jan 30, 2025

Of course i do that 😂
I notice this
image
I did add data-theme="dark" to the modal, and now it works
image
Maybe you forgot something on the first page load?

If i use settings, it fix on toggle

@barryvdh
Copy link
Owner Author

Hmm might be a timing issue then. What is your initial version, light? Or auto with light? It should set either dark or light anyways, so I’ll have to check.

@erikn69
Copy link
Contributor

erikn69 commented Jan 30, 2025

might be a timing issue then

I think the same, it would be better to add it to the openhandler render
No light, always dark like vampires 👍,

@erikn69
Copy link
Contributor

erikn69 commented Jan 30, 2025

would It be possible to add something like text-overflow: ellipsis; in the openhandler URL td?
it puts the entire URL and in the GET(big url) the horizontal scrollbar appears, it is annoying
image

maybe the header could be fixed

@barryvdh
Copy link
Owner Author

Fixed the theme and some default styling here: php-debugbar/php-debugbar#715 and removed some overrides in #1723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants