-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use php-debugbar dark theme, move to variables #1717
Conversation
I think this is done, but requires the latest php-debugbar beta. |
Hmm no, it should have. Did you do a hard refresh? |
Hmm might be a timing issue then. What is your initial version, light? Or auto with light? It should set either dark or light anyways, so I’ll have to check. |
I think the same, it would be better to add it to the openhandler render |
Fixed the theme and some default styling here: php-debugbar/php-debugbar#715 and removed some overrides in #1723 |
This is pending on php-debugbar/php-debugbar#703
This should make it easier to maintain both themes, if the existing variables are used. And a lot less CSS duplication.
Some color overrides should probably still be done in php-debugbar instead of here.
Note: This requires the feat-darktheme branch for debugbar to work.