Fix AggsProxy can't be imported | functional.py | utils.py (Tested with elasticsearch-dsl==8.13.1 & django==5.0.4) #316
Conversation
| @@ -67,7 +67,7 @@ | |||
| >>> | |||
| >>> model = Publisher # The model associate with this Document | |||
| """ | |||
| from elasticsearch_dsl.search import AggsProxy | |||
There was a problem hiding this comment.
We (elasticsearch-dsl team @ Elastic) cannot guarantee that this will continue to work in future releases of elasticsearch-dsl. AggsProxy is an internal class of this package, not intended to be used externally. Also consider that with this change users will be required to upgrade to elasticsearch-dsl==8.13.1 as any older versions will not work anymore.
In 8.13.1 we have added an implementation of the EmptySearch class that we intend to maintain going forward. My suggestion for a fix is something like this:
try:
# code for 8.13 (requires 8.13.1)
from elasticsearch import EmptySearch
except ImportError:
# 8.12 and older
# your definition of Empty Search here, including the original import of AggsProxy
There was a problem hiding this comment.
@miguelgrinberg I started implementing a solution in #319 .
However AggsProxy is used as well in another class. I am not sure how to tackle this one...
There was a problem hiding this comment.
@millerf I have missed that second usage. Unfortunately that one is more difficult, because it uses a few other private items in addtion to the AggsProxy instance. The whole idea of updating a Search instance in place goes against our design.
The two ways I can think of to "clean" one of these objects are:
- Create a brand new instance of the same class
- Run a query that is guaranteed to return no results
There was a problem hiding this comment.
@millerf I have missed that second usage. Unfortunately that one is more difficult, because it uses a few other private items in addtion to the
AggsProxyinstance. The whole idea of updating aSearchinstance in place goes against our design.The two ways I can think of to "clean" one of these objects are:
- Create a brand new instance of the same class
- Run a query that is guaranteed to return no results
Unfortunately I don't know enough about this plugin to get to do that... I am hoping someone will be able to help...
|
Can we have this implemented? I'm encountering this issue currently and would love to get it fixed |
|
See this approach that should be more future-proof (see this comment by Elastic team) |
Adding the fork below to your requirements.txt file can be a quick solution until this pull request is accepted