Some fixes #3
Open
Some fixes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick7
commented
Sep 11, 2022
•
patrick7
commented
- Load assets from /assets to display error pages correctly when loading from subfolders
- Always permit assets, which will make it working e.g. with allow/deny ip addresses
- Move error pages to /.nginx-errors to avoid collisions with the asset folder of some web apps
- Load assets from /assets to display error pages correctly when loading from subfolders - Always permit assets, which will make it working e.g. with allow/deny ip addresses
|
Sorry for the massive delay. I am happy to merge it if some other community members confirm the functionality and described benefits - as I personally no longer use nginx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.