Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MailMessagesController::index() ユニットテスト #4070

Merged
merged 2 commits into from
Dec 9, 2024
Merged

MailMessagesController::index() ユニットテスト #4070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a34e1ab
MailMessagesController::beforeFilter() ユニットテスト
dovanhung Dec 6, 2024
b8a51e5
MailMessagesController::index() ユニットテスト
dovanhung Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plugins/bc-mail/src/Controller/Admin/MailMessagesController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ public function initialize(): void
* @return void
* @checked
* @noTodo
* @unitTest
*/
public function beforeFilter(EventInterface $event)
{
Expand All @@ -80,6 +81,7 @@ public function beforeFilter(EventInterface $event)
* @return void
* @checked
* @noTodo
* @unitTest
*/
public function index(MailMessagesAdminServiceInterface $service, int $mailContentId)
{
Expand Down
63 changes: 59 additions & 4 deletions plugins/bc-mail/tests/TestCase/Controller/Admin/MailMessagesControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,23 @@

namespace BcMail\Test\TestCase\Controller\Admin;

use BaserCore\Test\Factory\ContentFactory;
use BaserCore\Test\Scenario\InitAppScenario;
use BaserCore\TestSuite\BcTestCase;
use BcMail\Controller\Admin\MailMessagesController;
use BcMail\Service\MailMessagesServiceInterface;
use BcMail\Test\Factory\MailContentFactory;
use Cake\Event\Event;
use Cake\TestSuite\IntegrationTestTrait;
use CakephpFixtureFactories\Scenario\ScenarioAwareTrait;

class MailMessagesControllerTest extends BcTestCase
{

/**
* Trait
*/
use ScenarioAwareTrait;
use IntegrationTestTrait;
/**
* set up
*
Expand All @@ -25,7 +36,8 @@ class MailMessagesControllerTest extends BcTestCase
public function setUp(): void
{
parent::setUp();
$this->MailMessagesController = new MailMessagesController($this->getRequest());
$this->loadFixtureScenario(InitAppScenario::class);
$this->MailMessagesController = new MailMessagesController($this->loginAdmin($this->getRequest()));
}

/**
Expand Down Expand Up @@ -53,7 +65,31 @@ public function testInitialize()
*/
public function testBeforeFilter()
{
$this->markTestIncomplete('このテストは、まだ実装されていません。');
ContentFactory::make([
'name' => 'name_test',
'plugin' => 'BcMail',
'type' => 'MailContent',
'url' => '/contact/',
'site_id' => 1,
'title' => 'お問い合わせ',
'entity_id' => 1
])->persist();

//正常テスト・エラーにならない
$request = $this->getRequest('/baser/admin/bc-mail/mail_messages/view/1/1');
$request = $this->loginAdmin($request);
$this->MailMessagesController = new MailMessagesController($request);
$event = new Event('filter');
$this->MailMessagesController->beforeFilter($event);

//異常テスト
$request = $this->getRequest('/baser/admin/bc-mail/mail_messages/view/2222/1');
$request = $this->loginAdmin($request);
$this->MailMessagesController = new MailMessagesController($request);
$event = new Event('filter');
$this->expectExceptionMessage('コンテンツデータが見つかりません。');
$this->expectException('BaserCore\Error\BcException');
$this->MailMessagesController->beforeFilter($event);
}

/**
Expand All @@ -69,7 +105,26 @@ public function testBeforeRender()
*/
public function testIndex()
{
$this->markTestIncomplete('このテストは、まだ実装されていません。');
$this->enableSecurityToken();
$this->enableCsrfToken();
// メールメッセージのデータを作成する
ContentFactory::make([
'plugin' => 'BcMail',
'type' => 'MailContent',
'url' => '/contact/',
'site_id' => 1,
'title' => 'お問い合わせ',
'entity_id' => 1,
])->persist();
MailContentFactory::make(['id' => 1])->persist();
$MailMessagesService = $this->getService(MailMessagesServiceInterface::class);
//テストデータベースを生成
$MailMessagesService->createTable(1);

//正常テスト
$this->get('/baser/admin/bc-mail/mail_messages/index/1');
$this->assertResponseOk();
$MailMessagesService->dropTable(1);
}

/**
Expand Down