simplify tabs keyboard handler

basher · Apr 22, 2024 · 53fef6b · 53fef6b
1 parent eccd7c4
commit 53fef6b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/ui/npm-shrinkwrap.json b/ui/npm-shrinkwrap.json
diff --git a/ui/package.json b/ui/package.json
@@ -2,7 +2,7 @@
     "name": "web-ui-boilerplate",
     "description": "UI boilerplate for websites/webapps using vanilla HTML/CSS/JavaScript, powered by Storybook, bundled by Parcel.",
     "author": "basher",
-    "version": "3.1.4",
+    "version": "3.1.5",
     "license": "ISC",
     "repository": {
         "type": "git",

diff --git a/ui/src/javascript/web-components/webui-tabs.ts b/ui/src/javascript/web-components/webui-tabs.ts
@@ -105,30 +105,28 @@ export default class WebUITabs extends HTMLElement {
 
     private bindKeyboardEvent(e: KeyboardEvent, index: number): void {
         // Stop page jumping with certain key events with 'e.preventDefault()'.
+        e.preventDefault();
+
         switch (e.code) {
             case 'ArrowRight':
-                e.preventDefault();
                 if (this.tabTriggers.length - index > 1) {
                     this.tabTriggers[index + 1].focus();
                     this.tabTriggers[index + 1].click();
                 }
                 break;
             case 'ArrowLeft':
-                e.preventDefault();
                 if (index > 0) {
                     this.tabTriggers[index - 1].focus();
                     this.tabTriggers[index - 1].click();
                 }
                 break;
             case 'Home':
-                e.preventDefault();
                 if (index !== 0) {
                     this.tabTriggers[0].focus();
                     this.tabTriggers[0].click();
                 }
                 break;
             case 'End':
-                e.preventDefault();
                 if (index !== this.tabTriggers.length - 1) {
                     this.tabTriggers[this.tabTriggers.length - 1].focus();
                     this.tabTriggers[this.tabTriggers.length - 1].click();