-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
canvasMode(BLEED/MARGIN/FACING_BLEEDS/FACING_MARGINS) fix for bounds() #256
Conversation
works so long as rectMode(CENTER) is on... means there may be an issue in the matrix?
forgot to edit this...
B less transform
What about this PR? Is it still valid? Should get a review |
I believe @trych ended up null+voiding this request when he did an overhaul recently on bounds? (canvasMode is still broken in current develop branch). I think his branch still needs to be added.. so I leave it up to him if this should be merged or not. |
This is still valid, but needs some re-work, as we now have global private variables to keep track of the x and y origin (as determined by the currently set canvas mode and page). Will have a look at this soon. |
Ok, I implemented Will merge. |
We've discovered that
|
I think this is also, because the bounds function itself is quite messy and broken and would need a lot of rework. Hence my suggestion to give it up and introduce |
The bounds was ignoring our canvasMode() - a potential bug since a long time that was occasionally run into.