Rework of collection functions + graphics() + textStyleRanges() #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- collection functions now always return a collection, also when callback functions are used - if a callback function returns false and aborts the loop, the collection up to this point is returned as an array - additional containers are allowed now for text collections and for items() - got rid of private function forEachTextCollection() as it was not needed anymore - rewriting of the collection functions docs, to make the functions easier to understand
|
Cool thing. What about some test coverage for the new functions? |
|
Added some testing. Will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This standardizes and cleans up the collection functions (e.g.,
words(),characters,items()etc.) and adds two new ones:graphics()andtextStyleRanges().Changes in detail:
forEach()forEachTextCollection()which was no longer neededgraphics()was added as discussed in Easier transforming of images #120 to allow changing the graphics within containers, like the graphic in a graphic frame.textStyleRanges()was added as discussed in Introduce b.addToText(), discontinue b.addToStory() #72 to allow looping over, well, text style ranges. :)stories()now allows for text frames or text objects as containers to get their parent story, as discussed in Introduce b.addToText(), discontinue b.addToStory() #72.@basiljs I will leave this up for review for a day or so, if there are no vetoes, I will go ahead and merge.