feat: Add optional info icon to top right of cards #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the PR @taigrr! I'll look into it and test it asap. |
taigrr
added a commit
to taigrr/homer
that referenced
this pull request
Oct 29, 2020
7 tasks
|
Hey @bastienwirtz any chance you could revisit this and #153 #154 and #147 ? |
bastienwirtz
requested changes
Nov 11, 2020
| .media-content { | ||
| overflow: hidden; | ||
| text-overflow: inherit; | ||
| } | ||
| .infolink { | ||
| font-family: "Font Awesome 5 Free"; |
There was a problem hiding this comment.
Have you tried without this line? as we use the <i> tag with the css class, I don't think that's needed (other icons works without it)
There was a problem hiding this comment.
I'll take a look right now.
There was a problem hiding this comment.
Specifically line 219 or the entire block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No new dependencies for this feature, screenshots attached below.
New options for services were bundled into the
Genericcard and allow an optional info link to be set with theinfoandinfotargetproperties.Note this UI/UX change moves the tag element from the top to the bottom right of the card to make room for the new icon.
Fixes #125
Type of change
Checklist:
config.ymlfile