Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #858 add labels to docker image #859

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

molhamalnasr
Copy link

Description

Summary of the Change
This pull request enhances the Dockerfile by adding OpenContainers labels to improve standardization and compatibility. The following labels have been added:

  • org.label-schema.schema-version="1.0"
  • org.label-schema.version="$VERSION_TAG"
  • org.opencontainers.image.title="Homer Image"
  • org.opencontainers.image.description="A dead simple static Home-Page for your server to keep your services on hand, from a simple yaml configuration file."
  • org.opencontainers.image.ref.name="b4bz/homer:22-alpine3.20"
  • org.opencontainers.image.version="$VERSION_TAG"
  • org.opencontainers.image.licenses="Apache-2.0 license"
  • org.opencontainers.image.source="https://github.com/bastienwirtz/homer"
  • org.opencontainers.image.url="https://homer-demo.netlify.app/"

Additionally, the .github/workflows/dockerhub.yml file has been updated to include the VERSION_TAG build argument.

Which Issue is Fixed
This pull request addresses issue #858 by incorporating the necessary labels into the Dockerfile.

Motivation and Context
The changes aim to align the Docker image with OpenContainers labeling guidelines, enhancing compatibility with tools like RenovateBot and improving the readability of the Changelog file using the org.opencontainers.image.source label.

Dependencies Required for This Change
No additional dependencies are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

Molham Al Nasr added 2 commits January 8, 2025 12:14
…nd pass the github.ref_name as VERSION_TAG build_args in docker/build-push-action pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant