WIP: Better options for creating challonge tournaments #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrantel
previously approved these changes
Jan 16, 2024
| @@ -59,6 +59,8 @@ def create_tournament(tournament: Tournament, *, is_private: bool): | |||
| "tournament_type": challonge_type, | |||
| "private": is_private, | |||
| "url": challonge_id, | |||
| "game_name": "Battlecode", | |||
There was a problem hiding this comment.
These changes just set up our tournaments to support replay url attachments in the future, correct?
There was a problem hiding this comment.
Also, will we need to merge #723 before merging this PR? b/c I see changes from camelcase to snakecase in that PR, but i'm not sure if that's a challonge v2 -> v2.1 change or challonge v1 -> v2 change
There was a problem hiding this comment.
Yup (and also they do more things)
updated PR description for more context
There was a problem hiding this comment.
ah good catch, idk if "game_name" is v2 or v2.1
I'll play it safe
n8kim1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #723
Attachments change: To actually let us add attachments (in our case, replay links). Attaching via API doesn't work but at least you can do manually
Game name: This is required not by the API v2 but by the tournament settings website. (Either they do frontend validation or use v1 of API.) So if you ever change the settings manually via website, you have to go back and add the game name, which gets really painful.... Also all our other tournaments have game name anyways, so might as well keep that around.
Also includes some dev notes