-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WebAssembly CPUs and OSes for configure_xcompile #1262
base: main
Are you sure you want to change the base?
Conversation
@novas0x2a any idea why we are getting these errors in CI?
The CPU and OS that I added are defined from platforms 0.0.9 onwards and I have updated the platforms dependency in 924f9c8. Is there something else that needs to be updated, perhaps a lockfile of some sort? |
Its probably the non-bzlmod code path - we don't explicitly depend on platforms at the moment which I guess is a bug; you probably need to add platforms to the workspace macro in |
Ok, let's handle that in #1263 since it is mostly unrelated to the changes here. |
As discussed in this #1247 (comment) this PR adds support for the WebAssembly CPUs and OSes.