feat: add support for settings volumes #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm0
commented
Jun 20, 2024
| @@ -22,7 +22,7 @@ oci_image_rule = _oci_image | |||
| oci_image_index = _oci_image_index | |||
| oci_push_rule = _oci_push | |||
|
|
|||
| def oci_image(name, labels = None, annotations = None, env = None, cmd = None, entrypoint = None, exposed_ports = None, **kwargs): | |||
| def oci_image(name, labels = None, annotations = None, env = None, cmd = None, entrypoint = None, exposed_ports = None, volumes = None, **kwargs): | |||
There was a problem hiding this comment.
Regarding the naming of the argument (referring to the discussion here: #503 (comment)).
The reference in that comment is about mounts in running containers, not the volume directive in images.
Volumes in images are specified here (and called volumes):
https://github.com/opencontainers/image-spec/blob/main/config.md#properties
Mounts are concrete attachments to paths inside the container (so they need a counterpart path on the host or an actual volume).
Volumes are merely metadata about an image, stating that it stores data there. (docker uses this to automatically create anonymous volumes, I do not know whether this behavior is specified).
thesayyn
approved these changes
Jun 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #406.