Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bazel-ios-fork to v2.9.0 #8

Draft
wants to merge 218 commits into
base: bazel-ios-fork
Choose a base branch
from

Commits on Jun 3, 2023

  1. Handle null Throwable message in asExecutionStatus (buildfarm#1357)

    Throwable indicates that the response to getMessage() may be null.
    werkt authored Jun 3, 2023
    Configuration menu
    Copy the full SHA
    82a485f View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. Update docs to include redis requirement (buildfarm#1359)

    Cleaned up some links and language
    werkt authored Jun 4, 2023
    Configuration menu
    Copy the full SHA
    4b5f2a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Configuration menu
    Copy the full SHA
    74455c8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f512d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Configuration menu
    Copy the full SHA
    bb6ba79 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Correct executeWorkers removal and expire (buildfarm#1367)

    Removed short circuit for executeWorkers which should never inspire
    publish
    Added memoized recentExecuteWorkers which will be delayed by currently
    const workerSetMaxAge
    Cleaned up getStorageWorkers, used grpc Deadline as premium, though
    already expired is awkward
    
    Storage removal is overzealous and will remove matching execute workers.
    Received worker changes continue to only affect storage.
    werkt authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c084fa1 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Adjust Server/Worker configs after parser (buildfarm#1370)

    Adjustments will make use of options. Ensure that they have the
    specified values from the commandline, and they have no checked
    exception throws.
    werkt authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d0b1d1d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2023

  1. Handle oversized FMBs in StubInstance by splitting (buildfarm#1377)

    FMBs over a specified size limit (4MB in practice from grpc limits) will
    be split log2n until under the limit to make requests.
    
    Tests added to verify this. Coverage of split behavior confirmed.
    
    Fixes buildfarm#1375
    werkt authored Jun 18, 2023
    Configuration menu
    Copy the full SHA
    d953f42 View commit details
    Browse the repository at this point in the history
  2. Missing directories not visited in validation (buildfarm#1378)

    A directory which is missing during the course of validation should not
    be identified as missing. This prevents a NPE and inspires validation to
    emit one MISSING violation per path to a missing directory for
    preconditions.
    
    Fixes buildfarm#1374
    werkt authored Jun 18, 2023
    Configuration menu
    Copy the full SHA
    dd52f13 View commit details
    Browse the repository at this point in the history
  3. Guard directory revisit with empty/missing checks (buildfarm#1379)

    Directories reevaluated only under the enumeration hierarchy must still
    be guarded against empty child directories in their checks, and must
    handle child directories missing in the index safely, with precondition
    failures matching their outputs. Order is not guaranteed in precondition
    output, but tests now guard this case.
    
    Fixes buildfarm#1299
    werkt authored Jun 18, 2023
    Configuration menu
    Copy the full SHA
    212e8a5 View commit details
    Browse the repository at this point in the history
  4. Output additions to RequestMetadata (buildfarm#1380)

    Include Action Mnemonic, Target Id, and Configuration Id in the bf-cat
    output suite for RequestMetadata.
    werkt authored Jun 18, 2023
    Configuration menu
    Copy the full SHA
    fe0fe8b View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. SEVERE for app.run failure (buildfarm#1382)

    An invocation of app.run which fails for any reason in the spring
    framework will exit silently. Ensure that errors are presented before
    exiting the application.
    werkt authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    5a1747d View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Enable custom latency buckets (buildfarm#1376)

    * Enable custom latency buckets
    
    * run formatter
    
    * Remove unused load from build
    
    * Run buildifier
    
    * update example config with infinity bucket
    
    ---------
    
    Co-authored-by: Trevor Hickey <[email protected]>
    amishra-u and luxe authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    e99878b View commit details
    Browse the repository at this point in the history
  2. Require fileStore for Directories interactions (buildfarm#1385)

    Avoid fileStore recalculation for entire trees to be deleted, instead
    expect the callers to provide a fileStore, and that the entire tree
    exists within it.
    werkt authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    3d72cbd View commit details
    Browse the repository at this point in the history
  3. Unwrap EEs on PutDirectoryException creation (buildfarm#1386)

    ExceutionExceptions wrap the actual exceptions of futures experienced
    during putDirectory, and add no tracing capacity. Unwrap these when
    thrown from failed futures.
    werkt authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5804462 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Retry downloads in CFC with copyExternalInput (buildfarm#1387)

    Bleed grpc exposure into a retrier for copyExternalInput invocations,
    and ensure that enough bytes have been provided from the requested blob
    before returning.
    werkt authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    7e9dd51 View commit details
    Browse the repository at this point in the history
  2. Skip isReadOnlyExecutable on symlinks (buildfarm#1383)

    The only presence of arbitrary symlinks in the CAS Filesystem is under
    directories. Symlinks are explicitly identified as
    non-readonly-executables. Prevent a dead symlink from throwing NSFE due
    to the readonly check.
    werkt authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    7be0264 View commit details
    Browse the repository at this point in the history
  3. Support UTF8 Strings in ffiReaddir (buildfarm#1388)

    Files are delivered via readdir in utf8 encoding (on linux for xfs at
    least), assume that posix will mandate this.
    werkt authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    6de1473 View commit details
    Browse the repository at this point in the history
  4. Revert context deadline guarantee from (buildfarm#1377)" (buildfarm#1389

    )
    
    This reverts mistakenly added checks for non-null deadlines in StubInstance.
    werkt authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    ee8b171 View commit details
    Browse the repository at this point in the history
  5. Rollback ensure deadline (buildfarm#1390)

    * Guard against fetchBlobFromWorker orphanization
    
    Any exception thrown by fetchBlobFromWorker will leave the blobObserver
    hanging. Ensure that the observer sees a failure and does not hang.
    
    * Restore FMB functionality included in revert.
    werkt authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    41a90be View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2023

  1. Interpret ExecDirException to Status (buildfarm#1391)

    Handle ExecDirExceptions in InputFetcher such that the client can
    observe a FAILED_PRECONDITION with PreconditionFailures that include
    Violations with VIOLATION_TYPE_MISSING to inspire virtuous loop
    reestablishment. A ViolationException acts as a container for this, and
    can be extended to include the components of a putDirectory. Interpret
    PutDirectoryExceptions with their imposed violations. Missing inputs at
    the time of execute, whether linked as immediate files or through the
    directory cache, will be interpreted as VIOLATION_TYPE_MISSING.
    werkt authored Jun 25, 2023
    Configuration menu
    Copy the full SHA
    b0ca1c2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    653da3f View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Handle inaccurate information in backplane for fmb call (buildfarm#1381)

    ### Problem 
    When workers die, their stored references are not removed from the backplane. This creates the possibility that new workers may come up with the same IP address or use an IP address previously used by another terminated host. As a result, the backplane becomes unreliable, requiring us to query each worker individually to find missing blobs. Clearly, this approach is not scalable since any problems encountered by a single worker can significantly impact the performance of the buildfarm.
    
    ### Past Work
    We made code modifications for the `findMissingBlobs` function to exclusively query the backplane, prs: buildfarm#1310, buildfarm#1333, and buildfarm#1342. This update implemented the `findMissingViaBackplane` flag. However, the above issues made the `findMissingViaBackplane` flag ineffective.
    
    ### Solution
    To address the issue of imposter workers, updated code to compare the start time of each worker (first_registered_at) with the insertion time of the digest. Any worker whose start time is later than the digest insertion time is considered an imposter worker. Also, the code removes imposter workers associated with the digest in the same function call.
    
    **first_registered_at**: Added new field first_registered_at to the worker data type. This field stores the initial start time of the worker. Worker  informs the backplane about its start time, which is the same as the creation time of the cache directory (where all digests are stored) on the worker's disk.
    
    **digest insert time**: The digest insertion time is calculated using the Time to Live (TTL) of the digest and the casExpire time. The formula for determining the digest insertion time is now() - configured casExpire + remaining ttl. In the current implementation, each worker updates the TTL of the digest upon completing the write operation. This means that the cas insert time in the backplane corresponds to the time when the last worker finished writing the digest on its disk.
    
    ### Testing
    Deployed the change to our buildfarm staging, and ran full monorepo build. To make sure that the code change solve terminated worker problem, terminated bunch of workers in the middle of build. This caused temporary not_found `error`, which eventually faded away (fmb call autocorrect blob location).
    <img width="1385" alt="Screenshot 2023-06-21 at 12 36 47 PM" src="https://github.com/bazelbuild/bazel-buildfarm/assets/119983081/62fcf8e0-847a-4632-b49e-cef2c17321dc">
    In the above graph terminated workers during first build.
    
    
    ### Future Improvement
    The above solution might not work if user updates `cas_expire` time between two deployments as algorithm to calculate `digest_insert_time` depends to `cas_expire` time. 
    
    closes buildfarm#1371
    amishra-u authored Jun 28, 2023
    Configuration menu
    Copy the full SHA
    ccee33b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e0e7f2c View commit details
    Browse the repository at this point in the history
  3. Exit server on transform token exhaustion

    When a server cannot acquire a transform token for an extended period of
    time, assume that it is malfunctioning and initiate a shutdown.
    werkt committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    8d85826 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Configuration menu
    Copy the full SHA
    a9936f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Supply a basic retrier to remote cas writes

    Worker loss can signal cascading failure and shutdown for execute-only
    peers. Ensure that a ReportResultStage seeing an SRE does not close the
    stage, and that there are basic retries for remote uploads.
    werkt committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    f74f270 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Update buildfarm-indexer for upstream updates

    Works with current redis-py-cluster 2.1.3
    werkt committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    f7eb74a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f893b5a View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Refactor findMissingBlobs method

    amishra-u authored and werkt committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    70903df View commit details
    Browse the repository at this point in the history
  2. incorporate feedback

    amishra-u authored and werkt committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    68318c5 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2023

  1. Configuration menu
    Copy the full SHA
    95719e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Shut down prometheus collector thread on CFC stop

    Prevents a hang on shutdown when redis is disconnected
    werkt committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    abcd8fc View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Output status code name on shard read error

    Use the proper name for a status code as presented when the read will
    not be retried.
    werkt committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    9b4bd6f View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Configuration menu
    Copy the full SHA
    8710642 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Configuration menu
    Copy the full SHA
    8315723 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Configuration menu
    Copy the full SHA
    77fee77 View commit details
    Browse the repository at this point in the history
  2. Upgrade opentelemetry javaagent to 1.28

    tokongs authored and werkt committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    b5754e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Update platforms

    keith committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9e7e633 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Merge pull request buildfarm#1422 from keith/ks/update-platforms

    Update platforms
    comius authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ae907b5 View commit details
    Browse the repository at this point in the history
  2. Add download rate metrics for buildfarm:worker (buildfarm#1418)

    * Add download metrics for buildfarm:worker
    
    * Run formatter
    
    * remove static
    
    * change IO_METRIC prometheus counter to static
    amishra-u authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    18ae72e View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Configuration menu
    Copy the full SHA
    1180a85 View commit details
    Browse the repository at this point in the history
  2. Separate channel for write api (buildfarm#1424)

    * Separate channel for write api
    
    * shutdown channel on termination
    amishra-u authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    8795c6e View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Configuration menu
    Copy the full SHA
    0abb176 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Fix deadlock when handling Write request (buildfarm#1442)

    * Fix deadlock by setting a timeout and removing the lock.
    
    * remove timeout as its not necessary
    
    * lint: delete unused import
    shirchen authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    882e86f View commit details
    Browse the repository at this point in the history
  2. Deliver RemoteCasWriter IOExceptions (buildfarm#1438)

    Interactions with RemoteCasWriter which declare IOExceptions should
    throw them exclusively for failures.
    werkt authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    773341c View commit details
    Browse the repository at this point in the history
  3. build: update maven mirrors

    jasonschroeder-sfdc authored and werkt committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    20d4ae5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a7f1ac2 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Update quick_start.md

    werkt committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    dfe9d3d View commit details
    Browse the repository at this point in the history
  2. Permit --prometheus_port to override config

    Specifying --prometheus_port for either server or worker will:
      Override the config value if delivered as int > 0, otherwise leave the
      config value alone.
    Since prometheusPort as configured <= 0 disables the server, this
    permits users to specify '0' to override the config with a disable
    switch.
    
    Updated quick_start docs to reflect this extra parameter.
    werkt committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    ed15779 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Configuration menu
    Copy the full SHA
    fb7cbd8 View commit details
    Browse the repository at this point in the history
  2. feat(redis): support rediss:// URIs for Redis-SSL

    Support "rediss://" (extra 's', like https) to indicate Redis-SSL
    connections.
    
    For Redis client identifier, we use the `identifier` passed to RedisShardBackplane.
    jasonschroeder-sfdc authored and werkt committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    a6fe207 View commit details
    Browse the repository at this point in the history
  3. chore: make code more readable

    jasonschroeder-sfdc authored and werkt committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    79eee49 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. Update rules_docker dependencies via injection

    Specify and patch more recent rules_go and bazel_gazelle per upstream
    patch. Docker images work with recent HEAD releases of bazel as a
    result.
    
    Depends on buildfarm#1453 resolution to actually build //...
    Fixes buildfarm#1440
    werkt committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    3305669 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Treat '.' working_directory segment as current

    Any '.' appearance as a segment should be considered to be the current
    directory in the search sequence of a working_directory path.
    werkt committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    7f86c47 View commit details
    Browse the repository at this point in the history
  2. Remove unused setExecuteResponseBuilder

    Method setExecuteResponseBuilder is not called in OperationContext
    werkt committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    90439ca View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Log on write errors

    werkt committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    8cc247f View commit details
    Browse the repository at this point in the history
  2. Use integer ids for Sqlite bidirectional index

    The cost in size for a single table bidirectional index is vast compared
    to the use of 3nf integer keys. Experimental estimates offer a decrease
    in file size of 90%.
    werkt committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f651cdb View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Configuration menu
    Copy the full SHA
    9f93972 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Manipulate worker set directly in RSB

    Avoid dependency on subscriber to update state changes when removing
    workers. This prevents an NPE which will occur invariably when workers
    are allowably configured with subscribeToBackplane: false.
    werkt committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    ec4b82c View commit details
    Browse the repository at this point in the history
  2. Remove publishTtlMetric option

    The individual metric controls for ttl are not necessary either for
    performance or feature support. Use Files' attributes acquisition
    mechanism for modified time.
    werkt committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    c48d600 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2abad58 View commit details
    Browse the repository at this point in the history
  4. Correct logging advisements for current Java

    Java logging definitions must now match java.util.logging.config.file,
    update these specifications in our README.md
    werkt committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    10189d6 View commit details
    Browse the repository at this point in the history
  5. Rename GracefulShutdownTest

    werkt committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    0c30cb0 View commit details
    Browse the repository at this point in the history
  6. Remove WebController

    werkt committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    5a0d8d6 View commit details
    Browse the repository at this point in the history
  7. Interrupt+Join operationQueuer/dispatchMonitor

    Use interrupt to halt the OperationQueuer.
    Join on both operationQueuer and dispatchMonitor before instance stop
    return.
    werkt committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    fa8dd6f View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Present operationNames by stage

    Include Match and Report Result stages in output
    Record the active operationName occupying slots in each of the stages
    and present them with WorkerProfile
    Avoid several unnecessary casts with interfaces for operation slot
    stages.
    werkt committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    60093db View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Remove subscribeToBackplane, adjust failsafe op

    A shard server is impractical without operation subscription, partition
    subscription confirmation between servers and workers.
    The failsafe execution is configuration that is likely not desired on
    workers. This change removes the failsafe behavior from workers via
    backplane config, and relegates the setting of failsafe boolean to
    server config. If the option is restored for workers, it can be added to
    worker configs so that configs may continue to be shared between workers
    and servers and retain independent addressability.
    werkt committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    9ff8e64 View commit details
    Browse the repository at this point in the history
  2. Removing AWS/GCP Metrics and Admin controls

    Internally driven metrics and scaling controls have low, if any, usage
    rates. Prometheus has largely succeeded independent publication of
    metrics, and externally driven scaling is the norm. These modules have
    been incomplete between cloud providers, and for the functional side of
    AWS, bind us to springboot. Removing them for the sake of reduced
    dependencies and complexity.
    werkt committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    b21ab2e View commit details
    Browse the repository at this point in the history
  3. Remove unused setOnCancelHandler

    Remove this unused OperationQueue feature which provides no invocations
    on any use.
    werkt committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    f97f048 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c2c1544 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. Configuration menu
    Copy the full SHA
    09015c9 View commit details
    Browse the repository at this point in the history
  2. Log write errors with worker address

    amishra-u authored and werkt committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    1041b57 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. Revert "Use integer ids for Sqlite bidirectional index"

    This reverts commit f651cdb.
    80degreeswest authored and werkt committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    30412ad View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    8379068 View commit details
    Browse the repository at this point in the history
  2. Cleanup matched logic in SWC listener

    Continue the loop while we have *not* matched successfully and avoid a
    confusing inversion in getMatched()
    werkt committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    fd20d13 View commit details
    Browse the repository at this point in the history
  3. Refactor SWC matcher and clarify Nullable

    Distinguish the valid/unique/propagating methods of entry listening.
    werkt committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    632fceb View commit details
    Browse the repository at this point in the history
  4. Interrupt matchStage to induce prepare shutdown

    The only signal to a waiting match that will halt its current listen
    loop for a valid unique operation is an interrupt.
    werkt committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7385c74 View commit details
    Browse the repository at this point in the history
  5. Specify example config with grpc target

    Distinguish target param with GRPC type storage from FILESYSTEM
    definition
    werkt committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    79cf648 View commit details
    Browse the repository at this point in the history
  6. Remove SpringBoot usage

    Reinstate prior usage of LoggingMain for safe shutdown, with added
    release mechanism for interrupted processes. All invoked shutdowns are
    graceful, with vastly improved shutdown speed for empty workers waiting
    for pipeline stages.
    werkt committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    d73628b View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Configuration menu
    Copy the full SHA
    6f88e34 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. refactor: code cleanup

    Tiny code cleanup
    jasonschroeder-sfdc authored and werkt committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    81122e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Log paths created on putDirectory

    Will include operation root and inform directory cache effectiveness.
    werkt committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    ad44854 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. Permit regex realInputDirectories

    Selecting realInputDirectories by regex permits flexible patterns that
    can yield drastic improvements in directory reuse for specialized
    deployments. runfiles in particular are hazardous expansions of
    nearly-execroot in the case of bazel.
    
    Care must be taken to match directories exclusively.
    The entire input tree is traversed for matches against expanded paths
    under the root, to allow for nested selection.
    Each match thus costs the number of input directories.
    Counterintuitively, OutputFiles are augmented to avoid the recursive
    check for OutputDirectories which only applies to actual reported
    results, resulting in a path match when creating the exec root.
    Regex style is java.util.Pattern, and must match the full input
    directory.
    werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    b31ffed View commit details
    Browse the repository at this point in the history
  2. Log execPath rather than the cache dir path

    This will include the path to the missed directory and the operation
    which required it.
    werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    1dec684 View commit details
    Browse the repository at this point in the history
  3. Shore up OutputDirectory for silence on duplicates

    Prevent adding duplicate realInputDirectories matches
    werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    6af857a View commit details
    Browse the repository at this point in the history
  4. Trigger realInputDirectories to have empty files

    Ensure that the last leg of the execution presents a directory, rather
    than the parent, per OutputDirectory's stamping.
    werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    71a928c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f8017bd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5d88e54 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    21448c3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    461cc5a View commit details
    Browse the repository at this point in the history
  9. feat: support --redis_uri command line option

    Support a `--redis_uri` command line option for start-up.
    jasonschroeder-sfdc authored and werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    b74531c View commit details
    Browse the repository at this point in the history
  10. docs(configuration): document the --redis_uri command line options

    also fixed some spelling typos.
    jasonschroeder-sfdc authored and werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    d860b27 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    10bf139 View commit details
    Browse the repository at this point in the history
  12. chore: bump rules_jvm_external

    Bumping 4.2 -> 5.3
    jasonschroeder-sfdc authored and werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    9d4c86c View commit details
    Browse the repository at this point in the history
  13. chore: bump rules_cc

    Bump fro 0.0.6 -> 0.0.9
    jasonschroeder-sfdc authored and werkt committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    5bc4564 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Configuration menu
    Copy the full SHA
    edf2211 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. build: override grpc dependencies with our dependencies

    Don't get transitive grpc dependencies, use the ones from our `maven_install(...)`
    jasonschroeder-sfdc authored and werkt committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    97e3b90 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96f239d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af3f34e View commit details
    Browse the repository at this point in the history
  4. feat: add Proto reflection service to shard worker

    To aid connection troubleshooting
    jasonschroeder-sfdc authored and werkt committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    380f8a1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7e7979d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1f9d01f View commit details
    Browse the repository at this point in the history
  7. Bug: Fix Blocked thread in WriteStreamObserver Caused by CASFile Write (

    buildfarm#1486)
    
    * Add unit test
    * Signal Write on complete
    amishra-u authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    578589f View commit details
    Browse the repository at this point in the history
  8. Pin the Java toolchain to remotejdk_17 (buildfarm#1509)

    Closes buildfarm#1508
    
    Cleanups:
    - remove the unused `ubuntu-bionic` base image
    - replace `ubuntu-jammy:jammy-java11-gcc` with `ubuntu-mantic:mantic-java17-gcc`
    - replace `amazoncorretto:19` with `ubuntu-mantic:mantic-java17-gcc`
    - swap inverted log file names in a file
    stefanobaghino authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    dfa5937 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f6459d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Support OutputPaths in OutputDirectory

    Specifying any number of OutputPaths will ignore OutputFiles (consistent
    with uploads). Where an OutputPath specifies an output directory, the
    action must be able to create the directory itself.
    werkt committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    018e177 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Permit Absolute Symlink Targets with configuration

    Partial specification of the absolute symlink response per REAPI.
    Remaining work will be in output identification.
    werkt committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    8b37013 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. chore: update bazel to 6.4.0 (buildfarm#1513)

    Trying to get more info on the Lombok stamping issue on Windows CI.
    See also bazelbuild/bazel#10363 and
    bazelbuild/bazel#18185
    jasonschroeder-sfdc authored Oct 29, 2023
    Configuration menu
    Copy the full SHA
    df9ce1d View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Configuration menu
    Copy the full SHA
    bd740c9 View commit details
    Browse the repository at this point in the history
  2. Create SymlinkNode outputs during upload (buildfarm#1515)

    Default disabled, available with createSymlinkOutputs option in Worker
    config.
    werkt authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    2a61f77 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. feat: Implement CAS lease extension (buildfarm#1455)

    Problem
    
        Enabling the findMissingBlobsViaBackplane flag in BuildfarmServer eliminates the need for the BuildfarmWorker's fmb API call. This BuildfarmWorker:fmb call was also responsible for tracking CAS entry access. As result, our CAS cache eviction strategy shifted from LRU to FIFO.
        When the findMissingBlobsViaBackplane flag is enabled, the buildfarm relies on the backplane as the definitive source for CAS availability. Since we don't update CAS expiry on each access, the backplane will independently expire CAS entries based on the specified cas_expire duration, even if they are actively being read.
    
    Solution
    
    Updated bfServer:fmb call to perform non-blocking fmb calls to workers, allowing these workers to record access for the relevant CAS entries.
    
    Extended expiry duration for available CAS entries in the backplane on each fmb call.
    
    With these changes, we can utilize Bazel's experimental_remote_cache_lease_extension and experimental_remote_cache_ttl flags for incremental builds.
    
    Closes buildfarm#1428
    amishra-u authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    76c2657 View commit details
    Browse the repository at this point in the history
  2. Bump org.json:json from 20230227 to 20231013 in /admin/main (buildfar…

    …m#1516)
    
    Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013.
    - [Release notes](https://github.com/douglascrockford/JSON-java/releases)
    - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md)
    - [Commits](https://github.com/douglascrockford/JSON-java/commits)
    
    ---
    updated-dependencies:
    - dependency-name: org.json:json
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    cfa2e18 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    ff00c8f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    afb0603 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9b5ec43 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f9ef75a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    20512f6 View commit details
    Browse the repository at this point in the history
  6. Read through external with query THROUGH=true

    Specifying a correlated invocation id with a uri containing a
    THROUGH=true query param will cause the CFC to read a blob through an
    external input stream, populating locally along the way. This permits
    client-based replication of blobs, and can enable N+1 replication and
    traffic balancing for reads.
    werkt committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    654032e View commit details
    Browse the repository at this point in the history
  7. Add --port option to worker

    Option to run the worker with a cmdline specification for its gRPC
    server port.
    werkt committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b4359c5 View commit details
    Browse the repository at this point in the history
  8. Restore worker --root cmdline specification

    Root cmdline specification has been broken since the config change of
    v2.
    werkt committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    5195809 View commit details
    Browse the repository at this point in the history
  9. Make bf-executor small blob names consistent

    Remove the size identification for small blobs when uploading with
    bf-executor.
    werkt committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    938c789 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Configured output size operation failure

    Permit installations to control the failure process for operations which
    produce outputs larger than the maxEntrySizeBytes. A default value
    of false retains the existing behavior which appears transient and
    blacklists the executed action key. When enabled, the action will fail
    under an invalid violation that indicates user error.
    werkt committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    87face1 View commit details
    Browse the repository at this point in the history
  2. Restore abbrev port as -p

    werkt committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    58faec9 View commit details
    Browse the repository at this point in the history
  3. Update zstd-jni for latest version

    There's been a few releases of it by now and this pulls the latest. For
    buildfarm, notable changes included performance enhancments during
    decompression.
    
    See:
    https://github.com/facebook/zstd/releases/tag/v1.5.5
    jerrymarino authored and werkt committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    cf6fc58 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Configuration menu
    Copy the full SHA
    6bc70e1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b226725 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. Detail storage requirements

    Update for further docs related to storage+type functionality
    Remove outdated Operation Queue worker definitions
    werkt authored Nov 4, 2023
    Configuration menu
    Copy the full SHA
    751ac90 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2bf3eae View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b6bddff View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Check for context cancelled before responding to error (buildfarm#1526)

    When a write fails because the write was already cancelled before due to something like deadline exceeded, we get an unknown error. The exception comes from here and when it gets to errorResponse(), it only checks if status code is cancelled. In this case the status code is unknown, so we need to check if context is cancelled to prevent responseObserver from being invoked
    
    The code change adds checking if context is cancelled and a unit test testing when the exception has context cancelled.
    justinwon777 authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    c490925 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a51c31 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Configuration menu
    Copy the full SHA
    7ea1a9f View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. updates

    luxe authored and werkt committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    a4822c1 View commit details
    Browse the repository at this point in the history
  2. updates

    luxe authored and werkt committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    f1ea9b5 View commit details
    Browse the repository at this point in the history
  3. updates

    luxe authored and werkt committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ccf763d View commit details
    Browse the repository at this point in the history
  4. updates

    luxe authored and werkt committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b7f5661 View commit details
    Browse the repository at this point in the history
  5. updates

    luxe authored and werkt committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    72b40ae View commit details
    Browse the repository at this point in the history
  6. Update ShardWorkerContext.java

    luxe authored and werkt committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    14c759b View commit details
    Browse the repository at this point in the history
  7. Update ShardWorkerContext.java

    luxe authored and werkt committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ca9bb92 View commit details
    Browse the repository at this point in the history
  8. [execution] allow tmpfs and cgroups enforcement

    tmpfs
    Previously we required bazel clients to opt-in with an exec_property. Now buildfarm has the ability to enforce tmpfs usage as part of deployment configuration.
    See: alwaysUseTmpFs: true
    
    cgroups
    cgroups was previously enabled via limitGlobalExecution. However, there was no way to opt-out of cgroups and opt-in to other restrictions. limitGlobalExecution is still required for accessing restrictions, but it will no longer guarantee cgroups is used. For that, deployments must set:
    See: alwaysUseCgroups: true
    
    Additional context
    We may also want to experiment with sandbox, but not cgroups in our deployment. There is currently no way to do this because enabling sandbox also requires enabling limitGlobalExecution, but doing so enables cgroups. By making these settings more granular we are able opt into and enforce particular execution wrappers.
    werkt authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    10e68c4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    35883a4 View commit details
    Browse the repository at this point in the history
  10. Update queues.md

    Refer to new camelized DMS fields.
    Expand predefined dynamic execution property name matches.
    werkt authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    9d80f4e View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Implement custom label header support for Grpc metrics interceptor (b…

    …uildfarm#1530)
    
    Add an option to provide a list of custom label headers to add to metrics.
    rastenis authored Nov 10, 2023
    Configuration menu
    Copy the full SHA
    aac33b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Specify direct guava dependency usage (buildfarm#1538)

    Testing with bazel HEAD using jdk21 compilation has revealed new
    direct dependencies on guava.
    werkt authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    f9882f7 View commit details
    Browse the repository at this point in the history
  2. Update lombok dependency for jdk21 (buildfarm#1540)

    Annotations under lombok were fixed for jdk21 in 1.18.28, update to
    current.
    werkt authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    69e0248 View commit details
    Browse the repository at this point in the history
  3. Reorganize DequeueMatchEvaluator (buildfarm#1537)

    Remove acceptEverything DequeueMatchSetting
    Place worker name in workerProvisions
    Only enable allowUnmatched effects on key mismatch
    Only acquire resources after asserting compatibility
    Update documentation to match changes
    werkt authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    339aa13 View commit details
    Browse the repository at this point in the history
  4. Upgrade com_google_protobuf for jvm compatibility (buildfarm#1539)

    Correct deprecated AccessController usage warning
    Requires a newer bazel than 6.4.0 for macos to choose unix toolchain with C++ std=c++14 specification for protobuf->absl dependency.
    werkt authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    025305a View commit details
    Browse the repository at this point in the history
  5. Create buildfarm-worker-base-build-and-deploy.yml (buildfarm#1534)

    Create a github workflow to build base buildfarm worker image.
    80degreeswest authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    f720909 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b7daba3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    dcff4f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Configuration menu
    Copy the full SHA
    52318f8 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Configuration menu
    Copy the full SHA
    e343393 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dae7f78 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b01889d View commit details
    Browse the repository at this point in the history
  4. Check for "cores" exec property as min-cores match (buildfarm#1548)

    The execution platform property "cores" is detailed in documentation as
    specifying "min-cores" and "max-cores". Match this definition and
    prevent "cores" from being evaluated as a strict match with the worker
    provision properties (with likely rejection).
    werkt authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    dcee798 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Consider output_* as relative to WD (buildfarm#1550)

    Per the REAPI spec:
    
    `The paths are relative to the working directory of the action
    execution.`
    
    Prefix the WorkingDirectory to paths used as OutputDirectory parameters,
    and verify that these are present in the layout of the directory for
    use.
    werkt authored Nov 19, 2023
    Configuration menu
    Copy the full SHA
    221eae9 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Implement Persistent Workers as an execution path (buildfarm#1260)

    Followup to buildfarm#1195
    
    Add a new execution pathway in worker/Executor.java to use persistent workers via PersistentExecutor, like DockerExecutor.
    
    Mostly unchanged from the form we used to experiment back at Twitter, but now with tests.
    
    Co-authored-by: Shane Delmore [email protected]
    wiwa authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    91587e7 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Locate Output Paths relative to WorkingDirectory (buildfarm#1553)

    * Locate Output Paths relative to WorkingDirectory
    
    Required as a corollary to OutputDirectory changes to consider outputs
    as relative to working directory.
    
    * Windows builds emit relativize paths with native separators
    werkt authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    a56b161 View commit details
    Browse the repository at this point in the history
  2. Remove incorrect external resolve of WD on upload (buildfarm#1554)

    Previous patch included a change in actionRoot parameter, expecting it
    to prefer the working directory rooted path to discover outputs. Might
    want to reapply this later, but for now leave the resolution in
    uploadOutputs.
    werkt authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    53e1fba View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Instance cleanups (buildfarm#1555)

    * Prevent multiple fetches of QueuedOperation
    
    Propagate the Tree in OperationContext for use during the persistent
    workers clause in Executor
    
    * Correct WSO and StubWriteOutputStream completion
    
    onCompleted should always be called on open requests when
    StubWriteOutputStreams are closed, even when completed early by the
    server.
    onCompleted must be delivered to responseObserver when onCompleted is
    invoked, lest a no-request write stream be left hanging to
    DEADLINE_EXCEEDED.
    
    * Explicit reset on WriteOffset 0 and blob write
    
    Avoid unnecessary queryWriteStatus requests when a WriteRequest
    appears with write offset 0 in WSO, and reset the stream initially for
    internal ServerInstance blob uploads.
    werkt authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    dd5c87b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d249393 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    a7ef693 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. add github action to package and publish the helm chart as a released…

    … artifact (buildfarm#1556)
    
    * bundle with helm
    publish release with gh cli
    
    * add a basic doc for the helm chart
    andrewrothstein authored Dec 5, 2023
    Configuration menu
    Copy the full SHA
    a06b095 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Configuration menu
    Copy the full SHA
    68182ec View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Write onNext requires onCompleted to follow (buildfarm#1565)

    For reasons passing understanding, a WriteResponse is not delivered to a
    client solely from onNext to be received by a client called via bsStub.
    onCompleted must follow the onNext for a timely delivery of the
    response, particularly when it occurs before an onCompleted from the
    client. This does not seem to affect the bazel client, which could
    indicate a difference in behavior between grpc versions, or simply that
    it manages to complete its upload completely ignorant of the early
    return status. More investigation is required.
    
    This will fix hanging builds which occur with exec-only workers failing
    to complete uploads to shard peers.
    werkt authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    e26a000 View commit details
    Browse the repository at this point in the history
  2. chore: update maven dependencies (buildfarm#1434)

    * chore(deps): bump com.amazonaws:aws-java-sdk-*
    
    Update to 1.12.544
    
    * chore(deps): bump org.redisson:redisson
    
    Update to 3.23.4
    
    * chore(deps): bump org.threeten:threetenbp
    
    Update to 1.6.8
    
    * chore(deps): bump org.snakeyaml:snakeyaml
    
    Update to 2.2
    
    * chore(deps): bump com.github.docker-java:docker-java
    
    * chore(deps): bump com.github.jnr:*
    
    Bumping all packages in this groupId to the latest.
    
    * chore(deps): bump com.github.serceman:jnr-fuse
    
    * chore(deps): bump com.github.oshi:oshi-core
    
    * chore(deps): bump com.google.auth:*
    
    Oauth libraries to the latest.
    
    * chore(deps): bump com.google.code.findbugs:jsr305
    
    * chore(deps): bump com.google.code.gson:gson
    
    * chore(deps): bump com.google.j2objc:j2objc-annotations
    
    * chore(deps): bump com.google.jimfs:jimfs
    
    * chore(deps): bump org.slf4j.slf4j-simple
    
    * chore(deps): bump com.jayway.jsonpath:json-path
    
    * chore(deps): bump io.netty:*
    
    * chore(deps): bump io.prometheus:*
    
    * chore(deps): bump junit:junit
    
    * chore(deps): bump org.apache.commons:commons-compress
    
    * chore(deps): bump org.apache.commons:commons-pool2
    
    * chore(deps): bump org.apache.commons:commons-lang3
    
    * chore(deps): bump commons-io:commons-io
    
    * chore(deps): bump me.dinowernli:java-grpc-prometheus
    
    * chore(deps): bump org.checkerframework:checker-qual
    
    * chore(deps): bump com.google.truth:truth
    
    * chore(deps): bump org.openjdk.jmh:*
    jasonschroeder-sfdc authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    859abb6 View commit details
    Browse the repository at this point in the history
  3. build: support compiling protobuf on macOS (buildfarm#1563)

    MacOS needs extra args to convince it to support C++14.
    jasonschroeder-sfdc authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    27194c7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1046e97 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. [tests] add unit test for local resources (buildfarm#1558)

    Add a unit test related to handling of local resources.
    luxe authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8d6e93f View commit details
    Browse the repository at this point in the history
  2. refactor: swap HealthStatusManager (buildfarm#1568)

    Swapping to the recommended class that isn't deprecated.
    
    Also, remove unnecessary String.format(...) with no format args.
    jasonschroeder-sfdc authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    fe2eba2 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. Configuration menu
    Copy the full SHA
    284845a View commit details
    Browse the repository at this point in the history
  2. feat: Redis password from file (buildfarm#1569)

    * feat(config): read Redis password from Redis URI or redis password file
    
    * tests(common): add a test for build.buildfarm.common.config.Backplane
    
    * docs(configuration): document redisPasswordFile
    
    Documenting new configuration parameter and the precedence of each password option.
    jasonschroeder-sfdc authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    8950953 View commit details
    Browse the repository at this point in the history
  3. docs: update AUTHORS and CONTRIBUTORS (buildfarm#1572)

    Adding myself and my copyright holder to `CONTRIBUTORS` and `AUTHORS`,
    respectively.
    jasonschroeder-sfdc authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    a4551f0 View commit details
    Browse the repository at this point in the history
  4. Identify Graceful Shutdown errors with severe (buildfarm#1574)

    Ensure that the log reflects these as errors, not just info
    werkt authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    f9140c4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f76893e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1fa3c43 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cf3ac77 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ce31446 View commit details
    Browse the repository at this point in the history
  9. Determine PipelineStage exception severity (buildfarm#1579)

    Select pipeline stage terminations based on exception type.
    InterruptedExceptions are terminable.
    Errors are uncaught and will terminate the stage.
    All others are logged with the pipeline continuing.
    werkt authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    2a6f68c View commit details
    Browse the repository at this point in the history
  10. Authored sandbox asNobody behavior (buildfarm#1580)

    Describe a boolean authored to supply the as-nobody wrapper published
    with buildfarm deployments that should serve as a quick mechanism for
    any install to use non-buildfarm (typically root) uids for actions.
    werkt authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    a0ec481 View commit details
    Browse the repository at this point in the history
  11. Provide Additional sandbox write paths in config (buildfarm#1581)

    Deployments may specify the paths that should be writable in sandbox
    werkt authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    9156123 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Declare stat block information for FuseCAS (buildfarm#1582)

    Useful so that a `du` and other block related tools work on the mounted
    directory.
    werkt authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    b48032b View commit details
    Browse the repository at this point in the history
  2. Try a new version of jekyll (buildfarm#1583)

    Current version is failing with a gem bundler error
    werkt authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    2097ef9 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Configuration menu
    Copy the full SHA
    d4de791 View commit details
    Browse the repository at this point in the history
  2. Remove rules k8s (buildfarm#1587)

    * build: remove rules_k8s
    
    The repo was archived May 12, 2023.
    
    * chore: remove unused k8s templates
    
    Please use the helm chart instead.
    
    * chore: Tiltfile updates to use helm chart instead
    jasonschroeder-sfdc authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    f320a81 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2870a3f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1b52ac0 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. [CI] skip server/worker audit on mac (buildfarm#1592)

    * do not audit server/worker jars on mac
    
    Avoid python dependencies on mac unit test CI
    
    * Update presubmit.yml
    
    comment reference to underlying issue
    
    ---------
    
    Co-authored-by: George Gensure <[email protected]>
    luxe and werkt authored Jan 2, 2024
    Configuration menu
    Copy the full SHA
    78b001c View commit details
    Browse the repository at this point in the history
  2. Helm Chart: latest image tags not v-prefixed (buildfarm#1591)

    * latest images with versions not v-prefixed
    
    * stage 0.2.0 of the Helm chart
    andrewrothstein authored Jan 2, 2024
    Configuration menu
    Copy the full SHA
    b5425e0 View commit details
    Browse the repository at this point in the history
  3. Update helm values to use safe defaults (buildfarm#1597)

    Removed values which will likely cause problems for execution and CFC saturation from helm chart:
    inputFetchStage_width and execute_stage_width both can be discovered from available processors
    maxSizeBytes for filesystem cas is automatically 90% of underlying file storage, down from a value 10x the actual bytes on storage requested below.
    path, names, and configuration for root, filesystem, and publicName can all be defaulted/derived safely.
    werkt authored Jan 2, 2024
    Configuration menu
    Copy the full SHA
    41b4494 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Properly balance over nodes, not slot ranges (buildfarm#1598)

    Slot ranges must not associate multiple times on a single node for use
    with balanced queues designed to be load balanced.
    werkt authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    088b8e1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b5db62 View commit details
    Browse the repository at this point in the history
  3. Use integer ids for Sqlite bidirectional index (buildfarm#1599)

    The cost in size for a single table bidirectional index is vast compared
    to the use of 3nf integer keys. Experimental estimates offer a decrease
    in file size of 90%.
    werkt authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    413021d View commit details
    Browse the repository at this point in the history
  4. Write cleanups (buildfarm#1600)

    * Guard against writeObserver null race
    
    * Avoid cancellation log for StubWriteOutputStream
    
    Cancels will happen for all server->worker uploads on context cancels
    initiated by clients, and are normal behaviors.
    
    * Guarantee null write response for onCompleted
    
    Avoid a complaint by gRPC that a client-streaming request was
    completed without a response
    
    * Reset remote CAS write on initial
    
    Prevents the StubWriteOutputStream from issuing an unnecessary initial
    queryWriteStatus.
    werkt authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    16b3aea View commit details
    Browse the repository at this point in the history
  5. fix: format without placeholders (buildfarm#1586)

    These instances of `format(...)` do not have placeholders and there's
    nothing to format.
    jasonschroeder-sfdc authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    51608f7 View commit details
    Browse the repository at this point in the history
  6. chore: Update proto file styling (buildfarm#1594)

    * chore: Update proto file styling
    
    * fix path
    
    * move protp styling to file
    
    * add new line at eof
    amishra-u authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    74b1f56 View commit details
    Browse the repository at this point in the history
  7. fix: Periodically Refresh Active Storage Workers With StartTime (buil…

    …dfarm#1549)
    
    * fix: Periodically Refresh Active Storage Workers With startTime
    amishra-u authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    e51f1e1 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Configuration menu
    Copy the full SHA
    c79b213 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. Configuration menu
    Copy the full SHA
    044597e View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Decode nodeId with jedis util SafeEncoder (buildfarm#1607)

    Node name strings provided via `cluster slots` will be byte arrays
    that require decoding. Use the inbuilt SafeEncoder from jedis which is
    used to decode all other strings.
    werkt authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    74316e7 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. build: start adopting bzlmod (buildfarm#1564)

    * build: start adopting bzlmod
    
    Only four bazel dependencies were found in the existing bzlmod registry (https://registry.bazel.build/)
    
    * build: swap io_bazel_rules_go for bzlmod
    
    * build: swap gazelle for bzlmod
    
    * tests: support bzlmod
    
    I don't know why. But it works.
    
    * build: leave breadcrumbs for bzlmod migration
    
    * build(chore): MODULE.bazel.lock
    
    * build: swap buildtools for buildifier_prebuilt
    
    There are conflicts with go tooling between buildtools and protobuf.
    jasonschroeder-sfdc authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    b62a4ce View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. fix(coverage): coverage numbers are not accurate (buildfarm#1609)

    The awk was pulling out the denominator of the metric, not the percent.
    Adjust the field.
    
    Before:
    ```
    current line coverage:  1625%
    current function coverage:  340%
    ```
    
    after:
    ```
    current line coverage:  42%
    current function coverage:  51%
    ```
    jasonschroeder-sfdc authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    373cb21 View commit details
    Browse the repository at this point in the history
  2. Add helm lint CI job. Split tag/release for the Helm chart from the…

    … entire repo with tags: `helm/X.Y.Z-b1` (buildfarm#1602)
    
    * add helm chart linting stage, bundle chart on helm/* tags
    
    * fix triggers
    
    * try try again
    
    * always lint before bundling
    
    * extract the helm chart version from the git tag ref
    
    * fix name
    
    * tickle the beast
    
    * too much stack overflow
    
    * better names
    
    * that's output
    
    * gussy up readme
    
    * simplify
    
    * stage 0.2.2
    
    * put extraVolumeMounts under .Values.shardWorker
    
    * omit defaults
    
    * leave out emacs gitignore
    
    * wrong example
    andrewrothstein authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b40c14b View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Publish storage worker and execute worker pool size in prometheus (bu…

    …ildfarm#1606)
    
    * Publish storage worker and execute worker pool size in prometheus
    
    * run formatter
    
    * add doc
    
    ---------
    
    Co-authored-by: Yuriy Belenitsky <[email protected]>
    amishra-u and 80degreeswest authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    d155c0b View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Configuration menu
    Copy the full SHA
    646d956 View commit details
    Browse the repository at this point in the history
  2. Provide hashedName in BackplaneStatus Queue Name (buildfarm#1616)

    Avoid stripping the existingHash, used to calculate the slot with suffix
    modifiers for queue balancing. Client presentation may also move to
    presenting each balanced queue name, removing the coordinated
    calculation on the client.
    
    The name could only have been used by a client prior for name
    presentation or determination of queue names in redis from slot
    arrangement.
    werkt authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    ea35e56 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. set expire and drop invocationId (buildfarm#1589)

    * set expire and drop invocationId
    
    * fix format
    
    * patch configuration doc
    
    * fix typo
    
    * re-run ci use luxe's patch
    
    * set expire when every active operation insert
    
    * fix return code
    
    * fix ci if statement
    
    ---------
    
    Co-authored-by: wangpengfei.pfwang <[email protected]>
    Co-authored-by: George Gensure <[email protected]>
    3 people authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    fe2c51c View commit details
    Browse the repository at this point in the history
  2. Add OSSF scorecard (buildfarm#1618)

    * feat: add OSSF Scorecards workflow
    
    Adding OSSF Scorecards workflow as github action. It runs periodially.  Output goes into Code Scanning alerts of GitHub.
    
    * docs(README): add some badges
    
    - OSSF Scorecard
    - License (from GitHub)
    - latest Release (from GitHub)
    jasonschroeder-sfdc authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    b7980a0 View commit details
    Browse the repository at this point in the history
  3. chore: remove rules_oss_audit (buildfarm#1617)

    Remove rules_oss_audit and accompanying documentation
    jasonschroeder-sfdc authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    8a7873b View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Configuration menu
    Copy the full SHA
    bb60196 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Configuration menu
    Copy the full SHA
    8a3abb6 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. fix template bugs with with (buildfarm#1631)

    * fix template bugs with with
    
    * stage chart v0.2.3
    andrewrothstein authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    60b3890 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1eb0528 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. Configuration menu
    Copy the full SHA
    cab70f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. migrate dependency to Bitnami Redis helm chart (buildfarm#1637)

    * rework for bitnami redis helm chart
    
    * still doesn't work tho less specified
    
    * disable redis pwd -- not for production use
    
    * chart/bitnami-redis:18.14.2
    
    * and later
    
    * stage chart v0.3.0
    andrewrothstein authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    14810a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge commit '14810a42ec8ea1fd65009d1183dd37a8ace0a0e3' into jackies/…

    …upgrade-bazel-buildfarm-to-v2.9.0
    chenj-hub committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d6c1859 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Configuration menu
    Copy the full SHA
    9938118 View commit details
    Browse the repository at this point in the history