Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add [email protected] #3625

Merged
merged 2 commits into from
Jan 21, 2025
Merged

feat: add [email protected] #3625

merged 2 commits into from
Jan 21, 2025

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Jan 20, 2025 •
edited
Loading

closes #3161

@bazel-io
Copy link
Member

Hello @Vertexwahn, modules you maintain (boost.pfr) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@wep21
Copy link
Contributor Author

wep21 commented Jan 20, 2025

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Jan 20, 2025
Vertexwahn
Vertexwahn previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@Vertexwahn Vertexwahn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wep21 in the case the BUILD.bazel file did not change we could symlink it...?

bazel-io
bazel-io previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@wep21
Copy link
Contributor Author

wep21 commented Jan 21, 2025

@fmeum Is it better to also make BUILD.bazel a relative symlink if they are same between different versions?

@Vertexwahn
Copy link
Contributor

Vertexwahn commented Jan 21, 2025 •
edited
Loading

@wep21 Since @fmeum suggested it here I would assume yes ;) - we should have an CI check for this...

@meteorcloudy
Copy link
Member

I actually don't think that's necessary, especially now we have a CI job to diff against the previous version. See https://github.com/bazelbuild/bazel-central-registry/actions/runs/12872254976/job/35887330503?pr=3625

Yes, indeed it saves a bit of space in the repo, but I don't think it really matters that much.

@bazel-io bazel-io dismissed stale reviews from Vertexwahn and themself January 21, 2025 11:00

Require module maintainers' approval for newly pushed changes.

@wep21
Copy link
Contributor Author

wep21 commented Jan 21, 2025

I've made BUILD.bazel a relative symlink of previous version.

bazel-io
bazel-io approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@fmeum fmeum merged commit 4e6dcbd into bazelbuild:main Jan 21, 2025
34 checks passed
@wep21 wep21 deleted the add-boost-pfr-1.87.0 branch January 21, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazel-io bazel-io bazel-io approved these changes

@Vertexwahn Vertexwahn Vertexwahn approved these changes

Assignees
No one assigned
Labels
skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

boost.pfr v1.84 (or newer)
5 participants
@wep21 @bazel-io @Vertexwahn @meteorcloudy @fmeum