Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bzl gazelle support overwrite resolve #535

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

eeelin
Copy link

@eeelin eeelin commented Aug 27, 2024

Support using gazelle:resolve directives to overwrite dependencies resolve.
Especially for some non-standard bzl naming, such as:

# gazelle:resolve starlark starlark @io_bazel_rules_docker//docker/util:run.bzl @io_bazel_rules_docker//docker/util
# gazelle:resolve starlark starlark @io_bazel_rules_docker//repositories:deps.bzl @io_bazel_rules_docker//repositories
# gazelle:resolve starlark starlark @io_bazel_rules_docker//repositories:repositories.bzl @io_bazel_rules_docker//repositories
# gazelle:resolve starlark starlark @rules_python//python:defs.bzl @rules_python//python:defs_bzl
# gazelle:resolve starlark starlark @npm//:vite/package_json.bzl @npm//:vite_bzl_library
# gazelle:resolve starlark starlark @npm//:docsify-cli/package_json.bzl @npm//:docsify-cli_bzl_library
# gazelle:resolve starlark starlark @npm//:typedoc/package_json.bzl @npm//:typedoc_bzl_library
# gazelle:resolve starlark starlark @npm//:api-spec-converter/package_json.bzl @npm//:api-spec-converter_bzl_library
# gazelle:resolve starlark starlark @rules_nodejs//nodejs:repositories.bzl @rules_nodejs//nodejs:bzl

@eeelin eeelin requested a review from achew22 as a code owner August 27, 2024 04:31
Copy link

google-cla bot commented Aug 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fmeum
Copy link
Contributor

fmeum commented Oct 25, 2024

@brandjon This would be pretty useful to have and looks simple enough, would you be available for a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants