Skip to content

Commit

Permalink
chore(release): don't use bazelisk from npm (#618)
Browse files Browse the repository at this point in the history
GitHub's default action runners image now includes bazelisk on the machine, so we are free to call `bazel` commands and be safe knowing the right version of Bazel will run.

A step before debugging why our npm package doesn't publish, likely not related, but @josephperrott points out we have some extra setup-node `uses` which is not desirable.
  • Loading branch information
alexeagle authored Aug 1, 2023
1 parent 03ce620 commit a42b252
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,6 @@ jobs:
with:
fetch-depth: 0

- uses: actions/setup-node@v3
with:
node-version: '14'

- name: Install Bazelisk
run: npm --global install @bazel/bazelisk@latest

- name: Build ibazel
run: bazel build //cmd/ibazel:ibazel --config release ${{ matrix.build_flags }} ${{ matrix.cpu_flag }}

Expand Down Expand Up @@ -100,12 +93,6 @@ jobs:
- uses: actions/download-artifact@v3
with:
path: ./npm-staging/bin
- uses: actions/setup-node@v3
with:
node-version: '14'

- name: Install Bazelisk
run: npm --global install @bazel/bazelisk@latest

- name: Prepare ibazel binaries
working-directory: ./npm-staging/bin
Expand Down

0 comments on commit a42b252

Please sign in to comment.