Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip incompatible_exclusive_test_sandboxed #16867

Closed
wants to merge 1 commit into from
Closed

Flip incompatible_exclusive_test_sandboxed #16867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/google/devtools/build/lib/analysis/test/TestConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ public static class TestOptions extends FragmentOptions {

@Option(
name = "incompatible_exclusive_test_sandboxed",
defaultValue = "false",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
effectTags = {OptionEffectTag.UNKNOWN},
metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/google/devtools/build/lib/rules/test/TestTargetPropertiesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ public void testTestWithCpusTagHasCorrectLocalResourcesEstimate() throws Excepti

@Test
public void testTestWithExclusiveRunLocallyByDefault() throws Exception {
useConfiguration("--noincompatible_exclusive_test_sandboxed");
scratch.file("tests/test.sh", "#!/bin/bash", "exit 0");
scratch.file(
"tests/BUILD",
Expand All @@ -73,6 +74,7 @@ public void testTestWithExclusiveRunLocallyByDefault() throws Exception {

@Test
public void testTestWithExclusiveIfRunLocally_notTaggedLocal() throws Exception {
useConfiguration("--noincompatible_exclusive_test_sandboxed");
scratch.file("tests/test.sh", "#!/bin/bash", "exit 0");
scratch.file(
"tests/BUILD",
Expand All @@ -93,7 +95,6 @@ public void testTestWithExclusiveIfRunLocally_notTaggedLocal() throws Exception

@Test
public void testTestWithExclusiveDisablesRemoteExecution() throws Exception {
useConfiguration("--incompatible_exclusive_test_sandboxed");
scratch.file("tests/test.sh", "#!/bin/bash", "exit 0");
scratch.file(
"tests/BUILD",
Expand All @@ -113,7 +114,6 @@ public void testTestWithExclusiveDisablesRemoteExecution() throws Exception {

@Test
public void testTestWithExclusiveIfRunLocally_notTaggedNoRemote() throws Exception {
useConfiguration("--incompatible_exclusive_test_sandboxed");
scratch.file("tests/test.sh", "#!/bin/bash", "exit 0");
scratch.file(
"tests/BUILD",
Expand Down
2 changes: 0 additions & 2 deletions src/test/shell/bazel/remote/remote_execution_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1987,12 +1987,10 @@ sh_test(
EOF

bazel test \
--incompatible_exclusive_test_sandboxed \
--remote_cache=grpc://localhost:${worker_port} \
//a:success_test || fail "Failed to test //a:success_test"

bazel test \
--incompatible_exclusive_test_sandboxed \
--remote_cache=grpc://localhost:${worker_port} \
--nocache_test_results \
//a:success_test >& $TEST_log || fail "Failed to test //a:success_test"
Expand Down