Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0] Update concept docs for symbolic macros and visibility #24535

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

brandjon
Copy link
Member

@brandjon brandjon commented Dec 2, 2024

These were meant to be included with #23857 (forked in #23945).

This is a rewrite to present the most relevant information, while eliding some technical detail. In particular, it reduces mention of visibility delegation to an afterthought, and focuses instead on the key insight and a single demonstrative example.

A subsequent CL will update visibility.md itself with appropriate details.

Work toward bazelbuild#23857.

PiperOrigin-RevId: 700736327
Change-Id: I543b57746e00bd9e62adb2b6d50ea25abc6e756f
A number of prose and code changes throughout the target visibility section, plus an entirely new subsection on symbolic macro particulars.

Work toward bazelbuild#23857.

PiperOrigin-RevId: 701986578
Change-Id: Id5f81fedd6c3b0a2e890f7281e9c315ba35905aa
@brandjon brandjon requested a review from a team as a code owner December 2, 2024 18:53
@github-actions github-actions bot added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Dec 2, 2024
@iancha1992 iancha1992 changed the title Update concept docs for symbolic macros and visibility [8.0.0] Update concept docs for symbolic macros and visibility Dec 2, 2024
@iancha1992 iancha1992 added this pull request to the merge queue Dec 2, 2024
Merged via the queue into bazelbuild:release-8.0.0 with commit 1b3a71b Dec 2, 2024
46 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants