Create parent folder for build event protocol files

[agustinmista]

Hi!

Some of our CI workflows rely on the --build_event_*_file flags to store the BEP events for further postprocessing. Concretely, our .bazelrc defines:

build --build_event_json_file=build/events.json

The problem is that we output these events files into a build folder that is .gitignored, and hence doesn't exist by default on a fresh clone of our repo. This forces any script that invokes bazel to make sure to mkdir -p build in advance.

We believe this is something that could be elegantly solved on the bazel side by creating the parent build folder if it doesn't exist. And fortunately, there is support for this in the underlying call to InstrumentationOutput.createInstrumentationOutput (added a couple of days ago in c13c669).

This PR sets createParent=true in the underlying call to InstrumentationOutput.createInstrumentationOutput made by BuildEventServiceModule.create.

We'll be happy to discuss about whether this should be the default behavior, or if it's worth it adding a new flag to enable it :)

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[agustinmista]

Not sure why the PR fails under darwin, the errors look unrelated, e.g.:

Server terminated abruptly (error code: 14, error message: 'Socket closed', log file: '/private/var/tmp/_bazel_buildkite/692ea664b0b8c296611e62f95b1b49ee/sandbox/darwin-sandbox/8313/execroot/_main/_tmp/4b1938da7d4f3c38b4ba75bf7f352f7f/root/6db04d6ef462efd508165bfd20c8851a/server/jvm.out')

Is this a known flakiness or is there something else I'm missing?

[sgowroji]

Hi @agustinmista, Below testcase is failing can you please take a look.
//src/test/shell/bazel:command_profiler_test FAILED

[agustinmista]

Hi @sgowroji!

Please check my previous comment. If I understand correctly, the //src/test/shell/bazel:command_profiler_test target fails under darwin with a "socket closed" error that seems (at least in principle) unrelated to my PR (log here). I'll be happy to dive deeper if the issue is on my side, but I'm not sure how can I help addressing that particular error.

Is there any way to re-trigger those checks to discard a possible intermittency?

[agustinmista]

@sgowroji can we re-run the failed checks to discard an intermittency?