Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject unresolved symlinks with BwoB #24833

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 6, 2025

Creating unresolved symlinks locally when building with --remote_download_outputs=minimal results in unnecessary I/O and may not even be supported by the host (e.g. on Windows). Instead, only create it in the remote action file system.

@fmeum fmeum force-pushed the unresolved-symlink-bwob branch 5 times, most recently from e073054 to 837ccff Compare January 7, 2025 08:37
fmeum added 2 commits January 7, 2025 10:35
Creating unresolved symlinks locally when building with `--remote_download_outputs=minimal` results in unnecessary I/O and may not even be supported by the host (e.g. on Windows). Instead, only create it in the remote action file system.
@fmeum fmeum force-pushed the unresolved-symlink-bwob branch from 837ccff to 7438799 Compare January 7, 2025 09:35
@fmeum fmeum marked this pull request as ready for review January 7, 2025 09:51
@fmeum fmeum requested a review from a team as a code owner January 7, 2025 09:51
@github-actions github-actions bot added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Jan 7, 2025
@meisterT meisterT requested a review from tjgq January 8, 2025 12:43
Copy link
Contributor

@tjgq tjgq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this. I'd prefer if we simply changed RAFS#createSymbolicLink to only create the symlink in the in-memory component (instead of adding a separate injection API). I'm curious to know if you tried that approach but ran into trouble elsewhere? (One issue is that we can't use RAFS in SymlinkTreeHelper since they would never be materialized on disk, but that already needs to change in light of #24867.)

@fmeum
Copy link
Collaborator Author

fmeum commented Jan 10, 2025

I would prefer that approach, in particular because it would also resolve (or at least help with) #21747. Should I give that a try in this PR? I remember that we weren't certain whether that would be safe.

@tjgq
Copy link
Contributor

tjgq commented Jan 10, 2025

I would prefer that approach, in particular because it would also resolve (or at least help with) #21747. Should I give that a try in this PR? I remember that we weren't certain whether that would be safe.

Let's give it a try in a separate PR and see what breaks? We can then reevaluate whether to attempt to fix whatever does, or come back to this one.

@fmeum
Copy link
Collaborator Author

fmeum commented Jan 10, 2025

I sent #24897 and will set the current PR to Draft.

@fmeum fmeum marked this pull request as draft January 10, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants