New frontend example for react-router #529
Conversation
| // | ||
| // Normally, this file is optional (https://reactrouter.com/explanation/special-files#entryservertsx) and react-router would use the copy in its own package as the default. | ||
| // However, when run in Bazel it is not able to find the default copy at runtime. | ||
| // TODO: Figure out how to make this work in Bazel. |
There was a problem hiding this comment.
The "broken" behavior is the fact that this file must be vendored into our repo.
The default behavior of react router is to fallback to its own internal copy of this file, when this file is omitted. Somehow though, when running in bazel, the fallback fails. I'm copying the fallback file into my own repo so that react router can find it.
alexeagle
force-pushed
the
11-26-new_frontend_example_for_react-router
branch
from
29fb9e2 to
d3f6389
Compare
|
I checked in rules_ts and actually we do have a very example for combining folders with rootDirs. |
With the recent merge between React Router and Remix, React Router v7 is a compelling option as a frontend framework and I wanted to try it out. Sending a PR because I thought others might benefit from my attempt at getting this working within Bazel!
Although the dev and production versions of the server are both working, this example is 95% of the way there. Unfortunately I'm not yet deeply familiar with
rules_js,rules_ts, or evenreact-router. I need a bit of help fixing the//react-router/app:app_typecheckand//react-router/app:testtests, they are each failing for a different reason::app_typecheckfails because it is missing some special typing files generated byreact-router. See their documentation here. I already wrapped thereact-router typegencommand into ajs_run_binarybut I couldn't figure out how to make thets_librarytarget accept the generated files as input.:testfails because thevitelibrary somehow doesn't containexpect. Honestly not sure why this is happening, the test code is taken almost exactly from https://github.com/bazelbuild/examples/blob/main/frontend/react/src/App.test.tsx.