[#6664] Add blaze mod ... runner implementation - 2/n
#6673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: CLion
3 tasks
tpasternak
reviewed
Aug 29, 2024
base/src/com/google/idea/blaze/base/command/CommandLineBlazeCommandRunner.java
Outdated
Show resolved
Hide resolved
tpasternak
approved these changes
Aug 29, 2024
base/src/com/google/idea/blaze/base/command/mod/BlazeModRunner.java
Outdated
Show resolved
Hide resolved
|
Sorry for the split comments in the review, but that's all. Other thins LGTM, thank you! |
tpasternak
requested changes
Aug 29, 2024
mtoader
force-pushed
the
mtoader/add-blaze-mod-runner
branch
from
eb42667
to
05b5ff9
Compare
|
Updated bits and changed the output of this command. @tpasternak PTAL |
tpasternak
approved these changes
Aug 29, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Discussion thread for this change
Issue number:
6664(#6664)Description of this change
This adds a
blaze mod ...runner into the blaze runner infrastructure. Will follow up wiring this into sync infrastructure and hooking the output ofdump_repo_mappinginto an in-memoryExternalWorkspaceDatavalue.