Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transitive_runtime_jars to KtKvmInfo #1022

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

scosenza
Copy link
Contributor

@scosenza scosenza commented Sep 7, 2023

Add transitive_runtime_jars to KtKvmInfo so we can store the java_info.transitive_runtime_jars for access in the IntelliJ Bazel Plugin's aspect

Add transitive_runtime_jars to KtKvmInfo so we can store the java_info.transitive_runtime_jars for access in the IntelliJ Bazel Plugin's aspect
@google-cla
Copy link

google-cla bot commented Sep 7, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@@ -37,6 +37,7 @@ KtJvmInfo = provider(
"outputs": "output jars produced by this rule. [intelij-aspect]",
"language_version": "version of kotlin used. [intellij-aspect]",
"transitive_compile_time_jars": "Returns the transitive set of Jars required to build the target. [intellij-aspect]",
"transitive_runtime_jars": "Returns the transitive set of Jars required to run the target. [intellij-aspect]",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you can already get this from the JavaInfo provider that will exist alongside the KtJvmInfo provider. Is that not the case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants