Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed 2to3 conversion without running tests #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cacods
Copy link

@cacods cacods commented Dec 11, 2020

Applied 2to3 to convert from Python 2 to Python 3. Python 3 version used: 3.5.2.

@bbangert
Copy link
Owner

I guess this presents the question of whether the goal is to still support Python 2. If that was the goal then six should probably be used to handle both versions since changing the unicode to str will definitely break existing users still on Python 2. I'm fine moving to Python 3 only support and dropping Python 2 if we move that to a new branch and version to reflect it just so that Python 2 users do not inadvertently get broken.

@cacods
Copy link
Author

cacods commented Dec 16, 2020

As Python 2 was gone last year, I think is a good idea to have a separate version and branch for Python 3.

@bbangert
Copy link
Owner

bbangert commented Jan 4, 2021

@cacods agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants