Merge pull request #12086 from bbc/dependabot/npm_and_yarn/typescript…

…-5.6.3 NEWSWORLDSERVICE-2067: Bump typescript from 5.4.5 to 5.6.3
bbc · Jan 16, 2025 · be0d7df · be0d7df
2 parents b6af157 + 8b2d6e1
commit be0d7df
Show file tree

Hide file tree

Showing 13 changed files with 20 additions and 18 deletions.
diff --git a/.yarn/cache/typescript-npm-5.4.5-8568a42232-d04a9e27e6.zip b/.yarn/cache/typescript-npm-5.4.5-8568a42232-d04a9e27e6.zip
diff --git a/.yarn/cache/typescript-npm-5.6.3-cc9b3687b0-c328e418e1.zip b/.yarn/cache/typescript-npm-5.6.3-cc9b3687b0-c328e418e1.zip
diff --git a/.yarn/cache/typescript-patch-1c74c14be0-dc4bec403c.zip b/.yarn/cache/typescript-patch-1c74c14be0-dc4bec403c.zip
diff --git a/.yarn/cache/typescript-patch-6e159bfddb-760f7d92fb.zip b/.yarn/cache/typescript-patch-6e159bfddb-760f7d92fb.zip
diff --git a/package.json b/package.json
@@ -249,7 +249,7 @@
     "timemachine": "0.3.2",
     "ts-jest": "29.2.5",
     "ts-loader": "9.5.1",
-    "typescript": "5.4.5",
+    "typescript": "5.6.3",
     "wait-on": "8.0.1",
     "webpack": "5.96.1",
     "webpack-bundle-analyzer": "4.10.2",

diff --git a/src/app/components/Text/index.tsx b/src/app/components/Text/index.tsx
@@ -29,7 +29,7 @@ const Text = forwardRef(function Text<T extends ElementType = 'span'>(
   }: Props<T> & Omit<ComponentPropsWithoutRef<T>, keyof Props<T>>,
   ref: ForwardedRef<HTMLElement>,
 ) {
-  const Component = as || 'span';
+  const Component: React.ElementType = as || 'span';
   return (
     <Component
       {...(ref && { ref })}

diff --git a/src/app/components/VisuallyHiddenText/index.tsx b/src/app/components/VisuallyHiddenText/index.tsx
@@ -7,6 +7,8 @@ interface VisuallyHiddenTextProps<T extends React.ElementType> {
   id?: string;
   tabIndex?: number;
   as?: T;
+  lang?: string;
+  children?: React.ReactNode;
 }
 
 const VisuallyHiddenText = <T extends React.ElementType>({
@@ -17,7 +19,7 @@ const VisuallyHiddenText = <T extends React.ElementType>({
   ...htmlAttributes
 }: VisuallyHiddenTextProps<T> &
   Omit<ComponentPropsWithoutRef<T>, keyof VisuallyHiddenTextProps<T>>) => {
-  const Component = as || 'span';
+  const Component: React.ElementType = as || 'span';
   return (
     <Component
       css={styles.visuallyHiddenText}

diff --git a/src/app/legacy/containers/ArticleMetadata/index.jsx b/src/app/legacy/containers/ArticleMetadata/index.jsx
@@ -11,8 +11,8 @@ const ArticleMetadata = ({
   firstPublished,
   lastPublished,
   section = '',
-  aboutTags = [],
-  mentionsTags = [],
+  aboutTags,
+  mentionsTags,
   lang,
   description,
   imageLocator = '',

diff --git a/src/app/legacy/containers/CpsFeaturesAnalysis/index.jsx b/src/app/legacy/containers/CpsFeaturesAnalysis/index.jsx
@@ -138,7 +138,7 @@ const PromoComponent = ({ promo, dir = 'ltr', sendOptimizelyEvents }) => {
 };
 
 const FeaturesAnalysis = ({
-  content = [],
+  content,
   parentColumns,
   sectionLabelBackground,
   sendOptimizelyEvents,

diff --git a/src/app/legacy/containers/CpsRecommendations/index.jsx b/src/app/legacy/containers/CpsRecommendations/index.jsx
@@ -45,7 +45,7 @@ const LabelComponent = styled(SectionLabel)`
   }
 `;
 
-const CpsRecommendations = ({ items = [] }) => {
+const CpsRecommendations = ({ items }) => {
   const { recommendations, translations, script, service, dir } =
     useContext(ServiceContext);
   const { enabled } = useToggle('cpsRecommendations');

diff --git a/src/app/legacy/containers/RelatedTopics/index.jsx b/src/app/legacy/containers/RelatedTopics/index.jsx
@@ -30,7 +30,7 @@ const StyledSectionLabel = styled(SectionLabel)`
 `;
 
 const RelatedTopics = ({
-  topics = [],
+  topics,
   mobileDivider = true,
   bar = true,
   className = '',

diff --git a/src/app/pages/ArticlePage/PagePromoSections/TopStoriesSection/TopStoriesItem/index.tsx b/src/app/pages/ArticlePage/PagePromoSections/TopStoriesSection/TopStoriesItem/index.tsx
@@ -24,7 +24,7 @@ const getArticleTopStoryItem = (item: TopStoryItem) => {
 
   const mediaType = item?.media?.format ?? '';
   const mediaDuration = item?.media?.duration ?? '';
-  const isPhotoGallery = item?.cpsType === 'PGL' ?? null;
+  const isPhotoGallery = item?.cpsType === 'PGL';
   const timestamp = item?.timestamp ?? null;
 
   const assetUri = item?.locators?.assetUri ?? '';

diff --git a/yarn.lock b/yarn.lock
@@ -18929,7 +18929,7 @@ __metadata:
     timemachine: "npm:0.3.2"
     ts-jest: "npm:29.2.5"
     ts-loader: "npm:9.5.1"
-    typescript: "npm:5.4.5"
+    typescript: "npm:5.6.3"
     undici: "npm:6.21.0"
     url-parse: "npm:1.5.10"
     uuid: "npm:8.3.2"
@@ -20444,23 +20444,23 @@ __metadata:
   languageName: node
   linkType: hard
 
-"typescript@npm:5.4.5":
-  version: 5.4.5
-  resolution: "typescript@npm:5.4.5"
+"typescript@npm:5.6.3":
+  version: 5.6.3
+  resolution: "typescript@npm:5.6.3"
   bin:
     tsc: bin/tsc
     tsserver: bin/tsserver
-  checksum: 10/d04a9e27e6d83861f2126665aa8d84847e8ebabcea9125b9ebc30370b98cb38b5dff2508d74e2326a744938191a83a69aa9fddab41f193ffa43eabfdf3f190a5
+  checksum: 10/c328e418e124b500908781d9f7b9b93cf08b66bf5936d94332b463822eea2f4e62973bfb3b8a745fdc038785cb66cf59d1092bac3ec2ac6a3e5854687f7833f1
   languageName: node
   linkType: hard
 
-"typescript@patch:typescript@npm%3A5.4.5#optional!builtin<compat/typescript>":
-  version: 5.4.5
-  resolution: "typescript@patch:typescript@npm%3A5.4.5#optional!builtin<compat/typescript>::version=5.4.5&hash=5adc0c"
+"typescript@patch:typescript@npm%3A5.6.3#optional!builtin<compat/typescript>":
+  version: 5.6.3
+  resolution: "typescript@patch:typescript@npm%3A5.6.3#optional!builtin<compat/typescript>::version=5.6.3&hash=5adc0c"
   bin:
     tsc: bin/tsc
     tsserver: bin/tsserver
-  checksum: 10/760f7d92fb383dbf7dee2443bf902f4365db2117f96f875cf809167f6103d55064de973db9f78fe8f31ec08fff52b2c969aee0d310939c0a3798ec75d0bca2e1
+  checksum: 10/dc4bec403cd33a204b655b1152a096a08e7bad2c931cb59ef8ff26b6f2aa541bf98f09fc157958a60c921b1983a8dde9a85b692f9de60fa8f574fd131e3ae4dd
   languageName: node
   linkType: hard