This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
Fix #104 method args modifers #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Bezzubov <[email protected]>
dennwc
reviewed
May 6, 2019
creachadair
changed the title
Instead of failing whole trasformation by assuming it's always nil, when it's not. Signed-off-by: Alexander Bezzubov <[email protected]>
bzz
force-pushed
the
fix-104-method-args-modifers
branch
from
f737e60 to
031a1fc
Compare
|
@dennwc @creachadair thank you for prompt reviews! Feedback addressed |
creachadair
approved these changes
May 6, 2019
dennwc
approved these changes
May 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104
See for details #104 (comment)
#120 is for subsequent work on annotation "depth".