fix(core): prevent drag click when multi selection is active (#1609)

* fix(core): prevent drag click when multi selection is active Signed-off-by: braks <[email protected]> * chore(changeset): add Signed-off-by: braks <[email protected]> --------- Signed-off-by: braks <[email protected]>
bcakmakoglu · Sep 6, 2024 · 43ed0a8 · 43ed0a8
1 parent f4bde90
commit 43ed0a8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/.changeset/swift-cups-pay.md b/.changeset/swift-cups-pay.md
@@ -0,0 +1,5 @@
+---
+"@vue-flow/core": patch
+---
+
+Prevent drag-click handler when multi selection is active.
diff --git a/packages/core/src/composables/useDrag.ts b/packages/core/src/composables/useDrag.ts
@@ -229,24 +229,14 @@ export function useDrag(params: UseDragParams) {
   }
 
   const eventEnd = (event: UseDragEvent) => {
-    if (!dragStarted) {
-      const pointerPos = getPointerPosition(event)
-
-      const x = pointerPos.xSnapped - (lastPos.x ?? 0)
-      const y = pointerPos.ySnapped - (lastPos.y ?? 0)
-      const distance = Math.sqrt(x * x + y * y)
-
-      // dispatch a click event if the node was attempted to be dragged but the threshold was not exceeded
-      if (distance !== 0 && distance <= nodeDragThreshold.value) {
-        onClick?.(event.sourceEvent)
-      }
-
-      return
+    if (!dragging.value && !multiSelectionActive.value) {
+      onClick?.(event.sourceEvent)
     }
 
     dragging.value = false
     autoPanStarted = false
     dragStarted = false
+    lastPos = { x: undefined, y: undefined }
 
     cancelAnimationFrame(autoPanId)