Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use nullish check when finding edge label renderer el #1214

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

bcakmakoglu
Copy link
Owner

🚀 What's changed?

  • Use nullish check when looking up the edge label renderer el to avoid potential calls of getElementsByClassname on null

@bcakmakoglu bcakmakoglu added the bug Something isn't working label Dec 12, 2023
@bcakmakoglu bcakmakoglu self-assigned this Dec 12, 2023
Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: 2d65e3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-flow/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-flow-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 6:51pm
vue-flow-typedoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 6:51pm

@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc December 12, 2023 18:43 Inactive
@bcakmakoglu bcakmakoglu force-pushed the fix/edge-label-renderer branch from 598264c to 2d65e3a Compare December 12, 2023 18:46
@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc December 12, 2023 18:48 Inactive
@bcakmakoglu bcakmakoglu merged commit ee97bf5 into release/1.27.0 Dec 12, 2023
@bcakmakoglu bcakmakoglu deleted the fix/edge-label-renderer branch December 12, 2023 18:56
@github-actions github-actions bot mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant