Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): check if injected state matches options and scope id #1562

Merged
merged 3 commits into from
Jul 27, 2024

Conversation

bcakmakoglu
Copy link
Owner

🚀 What's changed?

  • Prefer options id over scoped id when finding vue flow state
  • Check if injected vue flow state id matches options or scope id, otherwise create new state

@bcakmakoglu bcakmakoglu added the bug Something isn't working label Jul 27, 2024
@bcakmakoglu bcakmakoglu self-assigned this Jul 27, 2024
Copy link

vercel bot commented Jul 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-flow-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2024 6:16pm

Copy link

changeset-bot bot commented Jul 27, 2024

🦋 Changeset detected

Latest commit: 227c844

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-flow/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bcakmakoglu bcakmakoglu merged commit e83b1ef into next-release Jul 27, 2024
4 checks passed
@bcakmakoglu bcakmakoglu deleted the fix/state-injection branch July 27, 2024 18:21
@github-actions github-actions bot mentioned this pull request Jul 27, 2024
bcakmakoglu added a commit that referenced this pull request Jul 27, 2024
* fix(core): prefer options id when finding state

Signed-off-by: braks <[email protected]>

* fix(core): check if injected state matches options id

Signed-off-by: braks <[email protected]>

* chore(changeset): add

Signed-off-by: braks <[email protected]>

---------

Signed-off-by: braks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant