Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ccbc summary funding figures #3516

Merged
merged 7 commits into from
Sep 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## [1.190.1](https://github.com/bcgov/CONN-CCBC-portal/compare/v1.190.0...v1.190.1) (2024-09-04)

### Bug Fixes

- ccbc summary funding figures ([4ebd880](https://github.com/bcgov/CONN-CCBC-portal/commit/4ebd880288cddd11a9b695a7ea76dc28c457d682))

# [1.190.0](https://github.com/bcgov/CONN-CCBC-portal/compare/v1.189.1...v1.190.0) (2024-09-04)

### Features
Expand Down
2 changes: 1 addition & 1 deletion app/backend/lib/reporting/column_options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const columnOptions: Columns = [
{ width: 20 },
// column 20 (federal funding source)
{ width: 20 },
// column 21 (FHNA funding)
// column 21 (FNHA funding)
{ width: 20 },
// column 22 (Applicant amount)
{ width: 20 },
Expand Down
4 changes: 2 additions & 2 deletions app/backend/lib/reporting/gcpe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ const generateExcelData = async (
format: '$#,##0.00',
type: Number,
},
// FHNA funding
// FNHA funding
{ value: null },
// applicant amount
{
Expand Down Expand Up @@ -380,7 +380,7 @@ const generateExcelData = async (
format: '$#,##0.00',
type: Number,
},
// FHNA funding
// FNHA funding
{ value: null },
// applicant amount
{
Expand Down
2 changes: 1 addition & 1 deletion app/backend/lib/reporting/header.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ const HEADER_ROW: Row = [
wrap: true,
},
{
value: 'FHNA Funding',
value: 'FNHA Funding',
fontWeight: 'bold',
type: String,
height: 95,
Expand Down
2 changes: 1 addition & 1 deletion app/formSchema/analyst/summary/funding.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const funding: RJSFSchema = {
},
fhnaFunding: {
type: 'number',
title: 'FHNA Funding',
title: 'FNHA Funding',
},
otherFunding: {
type: 'number',
Expand Down
2 changes: 1 addition & 1 deletion app/formSchema/uiSchema/summary/fundingUiSchema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const fundingUiSchema = {
},
fhnaFunding: {
'ui:widget': 'MoneyWidget',
'ui:label': 'FHNA Funding',
'ui:label': 'FNHA Funding',
},
otherFunding: {
'ui:widget': 'MoneyWidget',
Expand Down
7 changes: 5 additions & 2 deletions app/lib/helpers/ccbcSummaryGenerateFormData.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,8 @@ const getFormDataFromApplication = (applicationData, allIntakes) => {
applicationData?.formData?.jsonData?.projectFunding
?.totalApplicantContribution,
cibFunding:
applicationData?.formData?.jsonData?.projectFunding?.cibFunding,
applicationData?.formData?.jsonData?.otherFundingSources
?.totalInfrastructureBankFunding,
fhnaFunding: null,
otherFunding: handleOtherFundingSourcesApplication(
applicationData?.formData?.jsonData?.otherFundingSources
Expand Down Expand Up @@ -340,7 +341,9 @@ const generateFormData = (applicationData, sowData, allIntakes) => {
applicationData.status === 'recommendation' ||
applicationData.status === 'closed' ||
applicationData.status === 'analyst_withdrawn' ||
applicationData.status === 'withdrawn'
applicationData.status === 'withdrawn' ||
applicationData.status === 'applicant_received' ||
applicationData.status === 'applicant_closed'
) {
const applicationFormData = getFormDataFromApplication(
applicationData,
Expand Down
2 changes: 1 addition & 1 deletion app/tests/backend/lib/reporting/testData.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export const regenerateGcpeReportQueryResult = {
},
{
wrap: true,
value: 'FHNA Funding',
value: 'FNHA Funding',
height: 95,
fontWeight: 'bold',
},
Expand Down
1 change: 1 addition & 0 deletions db/sqitch.plan
Original file line number Diff line number Diff line change
Expand Up @@ -658,3 +658,4 @@ tables/communities_source_data_001_service_account 2024-08-28T16:32:48Z Rafael S
@1.189.0 2024-08-30T18:07:26Z CCBC Service Account <[email protected]> # release v1.189.0
@1.189.1 2024-09-03T15:49:04Z CCBC Service Account <[email protected]> # release v1.189.1
@1.190.0 2024-09-04T19:57:18Z CCBC Service Account <[email protected]> # release v1.190.0
@1.190.1 2024-09-04T20:58:06Z CCBC Service Account <[email protected]> # release v1.190.1
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "CONN-CCBC-portal",
"version": "1.190.0",
"version": "1.190.1",
"main": "index.js",
"repository": "https://github.com/bcgov/CONN-CCBC-portal.git",
"author": "Romer, Meherzad CITZ:EX <[email protected]>",
Expand Down
Loading