Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in RFI template 1 upload #3527

Merged
merged 3 commits into from
Sep 4, 2024
Merged

fix: typo in RFI template 1 upload #3527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ffb323
fix: typo in RFI template 1 upload
RRanath Sep 4, 2024
fdb8ec4
Merge branch 'main' into NDT-512-Typo-on-RFI-page
rafasdc Sep 4, 2024
a3ca393
chore: release v1.190.4
ccbc-service-account Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## [1.190.4](https://github.com/bcgov/CONN-CCBC-portal/compare/v1.190.3...v1.190.4) (2024-09-04)

### Bug Fixes

- typo in RFI template 1 upload ([4ffb323](https://github.com/bcgov/CONN-CCBC-portal/commit/4ffb323ee2596983bc6762e55a048667c2419576))

## [1.190.3](https://github.com/bcgov/CONN-CCBC-portal/compare/v1.190.2...v1.190.3) (2024-09-04)

### Bug Fixes
Expand Down
2 changes: 1 addition & 1 deletion app/components/Analyst/RFI/TemplateDescription.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const TemplateDescription: React.FC<Props> = ({ templateNumber }) => {
* RFI upload for Template {templateNumber} automatically updates the
data for{' '}
{templateNumber === 1
? 'Final Eligible Households and Indigenous'
? 'Final Eligible Households and Indigenous Households'
: 'Total Eligible Costs and Total Project Costs'}{' '}
in the {link} section. Please verify the changes on the application
page.*
Expand Down
2 changes: 1 addition & 1 deletion app/tests/components/Analyst/RFI/RFIAnalystUpload.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ describe('The RFIAnalystUpload component', () => {

expect(
screen.getByText(
/RFI upload for Template 1 automatically updates the data for Final Eligible Households and Indigenous/
/RFI upload for Template 1 automatically updates the data for Final Eligible Households and Indigenous Households/
)
).toBeInTheDocument();

Expand Down
2 changes: 1 addition & 1 deletion app/tests/pages/analyst/application/[applicationId]/rfi/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ describe('The index page', () => {

expect(
screen.getByText(
/RFI upload for Template 1 automatically updates the data for Final Eligible Households and Indigenous/
/RFI upload for Template 1 automatically updates the data for Final Eligible Households and Indigenous Households/
)
).toBeInTheDocument();

Expand Down
1 change: 1 addition & 0 deletions db/sqitch.plan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,3 +661,4 @@ tables/communities_source_data_001_service_account 2024-08-28T16:32:48Z Rafael S
@1.190.1 2024-09-04T20:58:06Z CCBC Service Account <[email protected]> # release v1.190.1
@1.190.2 2024-09-04T21:14:02Z CCBC Service Account <[email protected]> # release v1.190.2
@1.190.3 2024-09-04T21:29:58Z CCBC Service Account <[email protected]> # release v1.190.3
@1.190.4 2024-09-04T21:45:26Z CCBC Service Account <[email protected]> # release v1.190.4
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "CONN-CCBC-portal",
"version": "1.190.3",
"version": "1.190.4",
"main": "index.js",
"repository": "https://github.com/bcgov/CONN-CCBC-portal.git",
"author": "Romer, Meherzad CITZ:EX <[email protected]>",
Expand Down
Loading