Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sow tab 7 total estimated project cost not importing #3629

Merged
merged 2 commits into from
Oct 23, 2024
+11 −4
Merged

fix: sow tab 7 total estimated project cost not importing #3629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eb0e5e
fix: sow tab 7 total estimated project cost not importing
rafasdc Oct 18, 2024
051d8c1
chore: release v1.202.2
ccbc-service-account Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## [1.202.2](https://github.com/bcgov/CONN-CCBC-portal/compare/v1.202.1...v1.202.2) (2024-10-23)

### Bug Fixes

- sow tab 7 total estimated project cost not importing ([1eb0e5e](https://github.com/bcgov/CONN-CCBC-portal/commit/1eb0e5e6a50294a1fdc85d42b0072acd99a7650c))

## [1.202.1](https://github.com/bcgov/CONN-CCBC-portal/compare/v1.202.0...v1.202.1) (2024-10-23)

### Bug Fixes
Expand Down
2 changes: 1 addition & 1 deletion app/backend/lib/sow_import/tab_7.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ const readBudget = async (sow_id, wb, sheet_name) => {
// -- SUMMARY OF ESTIMATED PROJECT COSTS --

// first pass - column B
for (let row = 1000; row < 1075; row++) {
for (let row = 1000; row < 1076; row++) {
const suspect = budget[row]['B'];
let value;
if (suspect === undefined) continue;
Expand Down
4 changes: 2 additions & 2 deletions app/tests/backend/lib/sow_tab_7.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1787,7 +1787,7 @@ describe('sow tab 7 tests', () => {
eligibleMobile: 0,
totalEligibleCosts: 500000,
totalIneligibleCosts: 250000,
totalProjectCost: '',
totalProjectCost: 750000,
},
totalCostsPerCostCategory: {
directLabour: { cost: 80000, percentOfTotalEligibleCosts: 0.16 },
Expand Down Expand Up @@ -2015,7 +2015,7 @@ describe('sow tab 7 tests', () => {
eligibleMobile: 0,
totalEligibleCosts: 500000,
totalIneligibleCosts: 250000,
totalProjectCost: '',
totalProjectCost: 750000,
},
totalCostsPerCostCategory: {
directLabour: { cost: 80000, percentOfTotalEligibleCosts: 0.16 },
Expand Down
1 change: 1 addition & 0 deletions db/sqitch.plan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,3 +714,4 @@ tables/application_form_template_9_data 2024-09-25T22:50:17Z Rafael Solorzano <6
@1.201.1 2024-10-18T23:48:24Z CCBC Service Account <[email protected]> # release v1.201.1
@1.202.0 2024-10-21T21:32:01Z CCBC Service Account <[email protected]> # release v1.202.0
@1.202.1 2024-10-23T14:59:42Z CCBC Service Account <[email protected]> # release v1.202.1
@1.202.2 2024-10-23T20:54:15Z CCBC Service Account <[email protected]> # release v1.202.2
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "CONN-CCBC-portal",
"version": "1.202.1",
"version": "1.202.2",
"main": "index.js",
"repository": "https://github.com/bcgov/CONN-CCBC-portal.git",
"author": "Romer, Meherzad CITZ:EX <[email protected]>",
Expand Down
Loading